FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

refactor(network): extract helpers and cut cyclomatic complexity by gmmcosta15 · Pull Request #309 · BlocksTechnology/BlocksScreen · GitHub

refactor(network): extract helpers and cut cyclomatic complexity - #309

Open
gmmcosta15 wants to merge 1 commit into
chore/network-drop-debug-logs-docstringsfrom
refactor/network-extract-helpers
Open

refactor(network): extract helpers and cut cyclomatic complexity#309
gmmcosta15 wants to merge 1 commit into
chore/network-drop-debug-logs-docstringsfrom
refactor/network-extract-helpers

Conversation

Copy link
Copy Markdown
Collaborator

Description

  • Code refactor

Stacked on #2, review after it merges.

Behaviour-neutral motion only, extracts helpers to cut cyclomatic complexity below the C901 threshold (10). Reviewable as pure motion.

  • Extract _gather_ap_properties, _gather_settings, _vlan_*, _prefix_to_mask, _parse_ipv4_settings, _unwrap, _setting, _delete_connections_where, _delete_all_connections_by_id, _find_ap_props, _reload_connections
  • models.py cleanup

Tests

All 5 gates pass standing alone, including ruff check --select C901 over the network layer. No behaviour change (pure extraction).

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL