This repository was archived by the owner on Dec 2, 2020. It is now read-only.
Constantly showing the most recent selected circle - #250
Open
mozharovsky wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
* Constantly showing the most recent circle selected * A property for getting the selected circle (it’s going to be NULL on reload)
Copy link
Copy Markdown
Author
|
Guys, does this pull request seem to be merged in the upcoming version? I have more features implemented based on these changes. :] |
Sorry, something went wrong.
Comment thread
Classes/BEMSimpleLineGraphView.h
| @property (nonatomic) BOOL alwaysShowSelectedCircle; | ||
|
|
||
| /// The graphs's most recently selected circle. | ||
| @property (strong, nonatomic, nullable) BEMCircle *selectedCircle; |
Copy link
Copy Markdown
Owner
There was a problem hiding this comment.
Why expose the property selectedCircle publicly?
If necessary, shouldn't it be read-only?
Sorry, something went wrong.
Copy link
Copy Markdown
Owner
|
Hi @mozharovsky, |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reload)