FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Feature Enhancement: Supply current popUp index parameter for lineGraph by xuzhiming · Pull Request #256 · Boris-Em/BEMSimpleLineGraph · GitHub

This repository was archived by the owner on Dec 2, 2020. It is now read-only.
/ BEMSimpleLineGraph Public archive

Feature Enhancement: Supply current popUp index parameter for lineGraph - #256

Open
xuzhiming wants to merge 5 commits into
Boris-Em:masterfrom
xuzhiming:master
ConversationCommits (5)ChecksFiles changed
Open

Feature Enhancement: Supply current popUp index parameter for lineGraph#256
xuzhiming wants to merge 5 commits into
Boris-Em:masterfrom
xuzhiming:master

Conversation

xuzhiming commented Mar 10, 2016

Copy link
Copy Markdown

Summary

supply current popUp index parameter for popUpSuffixForlineGraph and popUpPrefixForlineGraph

Feature Enhancement

This pull request enhance the following features:

  • #We sometimes may need know current popUp index when we display popUp suffix/prefix.

Notes

  • I have run and ensured that this pull request passes all XCTests

Boris-Em reviewed Mar 10, 2016
View reviewed changes
Comment thread Classes/BEMSimpleLineGraphView.h Outdated
@param graph The graph object requesting the total number of points.
@return The suffix to append to the popup report. */
- (NSString *)popUpSuffixForlineGraph:(BEMSimpleLineGraphView *)graph;
- (NSString *)popUpSuffixForlineGraph:(BEMSimpleLineGraphView *)graph index:(NSUInteger)index;

Boris-Em Mar 10, 2016

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please rename the method to - (NSString *)popUpSuffixForlineGraph:(BEMSimpleLineGraphView *)graph atIndex:(NSUInteger)index;.
The comment also needs to be updated.

Boris-Em commented Mar 10, 2016

Copy link
Copy Markdown
Owner

Hi @xuzhiming,
First of all, thanks a lot for your contribution! I added a few in line comments. Please address those so that we can merge your pull request.
Let me know if you have any questions!

xuzhiming commented Mar 11, 2016

Copy link
Copy Markdown
Author

ok, I'll address those issues soon.

update comments and parameter's name for popUpSuffixForlineGraph and …
fb434aa 
…popUpPrefixForlineGraph.

remove awakeFromNib to avoid commonInit be called twice.
use the longestString index for popUp.

xuzhiming commented Mar 14, 2016

Copy link
Copy Markdown
Author

Hi @Boris-Em , please check the latest commit.

Sam-Spencer commented Mar 19, 2016

Copy link
Copy Markdown
Collaborator

This looks great! It is a breaking change. Could you deprecate the old methods?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement rework pull

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL