Actionable comments posted: 2

lib/app/modules/manageTaskServer/controllers/manage_task_server_controller.dart (3)

45-45: Remove instructional comment.

The // ⬅️ ADD THIS marker should be removed before merging.

🧹 Proposed cleanup

-      trust = taskrc.trust; // ⬅️ ADD THIS
+      trust = taskrc.trust;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@lib/app/modules/manageTaskServer/controllers/manage_task_server_controller.dart`
at line 45, Remove the leftover instructional comment marker from the assignment
"trust = taskrc.trust;" in the manage_task_server_controller.dart controller so
the line reads cleanly without the "// ⬅️ ADD THIS" suffix; locate the
assignment to the variable trust in the controller method where taskrc is used
(e.g., the controller that assigns taskrc.trust to trust) and delete only the
trailing comment text.

---

101-101: Remove instructional comment.

Same as previous - remove the // ⬅️ ADD THIS development marker.

🧹 Proposed cleanup

-          trust = taskrc.trust; // ⬅️ ADD THIS
+          trust = taskrc.trust;

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@lib/app/modules/manageTaskServer/controllers/manage_task_server_controller.dart`
at line 101, Remove the development marker comment next to the assignment "trust
= taskrc.trust;" in the ManageTaskServerController (or the controller method
where that assignment occurs); simply delete the trailing comment text "// ⬅️
ADD THIS" so the line becomes a plain assignment without any instructional
marker, leaving surrounding logic and the variable names unchanged.

---

169-171: Logic is correct; remove instructional comment.

The conditional appending of taskd.trust is implemented correctly with proper null-safety checks. However, the // ⬅️ ADD THIS comment should be removed.

🧹 Proposed cleanup

        if (trust?.isNotEmpty == true) {
-          taskrcContent += "\ntaskd.trust=$trust"; // ⬅️ ADD THIS
+          taskrcContent += "\ntaskd.trust=$trust";
        }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@lib/app/modules/manageTaskServer/controllers/manage_task_server_controller.dart`
around lines 169 - 171, Remove the inline instructional comment after the append
line so the code reads cleanly; locate the conditional that checks `if
(trust?.isNotEmpty == true)` in the ManageTaskServerController (or the method
where `taskrcContent` is built) and delete the trailing comment `// ⬅️ ADD THIS`
from the line `taskrcContent += "\ntaskd.trust=$trust";` leaving the logic
unchanged.

lib/app/utils/taskserver/taskrc.dart (2)

24-24: Remove instructional comment before merging.

The comment // ⬅️ ADD THIS LINE appears to be a development/instruction marker that should be removed before the code is merged.

🧹 Proposed cleanup

-    var trust = taskrc['taskd.trust']; // ⬅️ ADD THIS LINE
+    var trust = taskrc['taskd.trust'];

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@lib/app/utils/taskserver/taskrc.dart` at line 24, Remove the
development/instruction marker from the inline comment on the variable
declaration for trust: locate the line that declares var trust =
taskrc['taskd.trust']; in taskrc.dart and delete the trailing comment "// ⬅️ ADD
THIS LINE" so the code only contains the declaration (var trust =
taskrc['taskd.trust'];) with no instructional comments.

---

30-30: Remove instructional comment.

Same as above - remove the development marker comment.

🧹 Proposed cleanup

-      trust: trust, // ⬅️ ADD THIS LINE
+      trust: trust,

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@lib/app/utils/taskserver/taskrc.dart` at line 30, Remove the development
marker comment trailing the property assignment "trust: trust" (the inline
comment "// ⬅️ ADD THIS LINE") so the code only contains the property
assignment; locate the "trust: trust" entry in the taskrc.dart
object/constructor and delete the instructional comment while preserving the
assignment and formatting.

test/models/filters_test.dart (1)

32-67: Add assertions for the new status filters.

The fixture now wires completedFilter and deletedFilter, but none of the tests call those toggles or assert the initial field values. A constructor/callback wiring bug in the new parameters would still pass here.

🧪 Suggested test additions

     test('should correctly initialize with given parameters', () {
       expect(filters.pendingFilter, pendingFilter);
       expect(filters.waitingFilter, waitingFilter);
+      expect(filters.completedFilter, completedFilter);
+      expect(filters.deletedFilter, deletedFilter);
       expect(filters.projectFilter, projectFilter);
       expect(filters.tagFilters.tagUnion, tagUnion);
       expect(filters.tagFilters.tags, tags);
     });
+
+    test('should correctly toggle completed filter', () {
+      filters.toggleCompletedFilter();
+      expect(completedFilter, isTrue);
+
+      filters.toggleCompletedFilter();
+      expect(completedFilter, isFalse);
+    });
+
+    test('should correctly toggle deleted filter', () {
+      filters.toggleDeletedFilter();
+      expect(deletedFilter, isTrue);
+
+      filters.toggleDeletedFilter();
+      expect(deletedFilter, isFalse);
+    });

Also applies to: 71-119

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/models/filters_test.dart` around lines 32 - 67, Tests are missing
assertions and invocations for the new completedFilter and deletedFilter wiring
in the Filters fixture; add checks that completedFilter and deletedFilter
initialize to the expected values and call toggleCompletedFilter and
toggleDeletedFilter to verify the callbacks flip their booleans. Locate the
Filters construction in the test (the Filters(...) instance) and add assertions
that completedFilter and deletedFilter equal the fixture vars, then invoke
toggleCompletedFilter() and toggleDeletedFilter() and assert the corresponding
completedFilter and deletedFilter values have toggled; do the same in the other
fixture block referenced (lines ~71-119) to cover both cases.

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@lib/app/modules/home/controllers/home_controller.dart`:
- Around line 3-4: The code tries to instantiate the abstract Sentences class
and references a non-existent Routes.TASKSERVER_SETUP; change the Sentences()
instantiation to use the concrete implementation or factory (e.g., the project's
concrete subclass or a getSentences() provider) so you don't instantiate an
abstract class, and fix the route reference by replacing Routes.TASKSERVER_SETUP
with the actual route constant defined in your routes file (or add a
TASKSERVER_SETUP constant to the routes configuration if that route is intended
to exist); update all occurrences (the Sentences() construction and the
Routes.TASKSERVER_SETUP usages) to use the correct concrete class/factory and
valid route constant.
- Around line 596-630: The current implementation can dismiss the wrong banner
because it clears all banners and uses scaffold-wide
hideCurrentMaterialBanner(); modify showTaskServerNotConfiguredBanner to capture
and track the specific ScaffoldFeatureController returned by
messenger.showMaterialBanner (e.g. store it in a field like
_taskServerBannerController) and use that controller.close() to dismiss this
banner; also create and store a Timer (e.g. _taskServerBannerTimer) for the 5s
auto-dismiss so you can cancel it when either TextButton is pressed or before
showing a new banner, remove the global messenger.clearMaterialBanners() call,
and ensure both button handlers and the timer clear/reset taskServerBannerShown
and null out the controller and timer so the lifecycle is tied to this banner
instance only.

---

Outside diff comments:
In `@lib/app/modules/home/controllers/home_controller.dart`:
- Around line 238-257: _profileSet currently reloads many tab-backed filters but
omits the two non-tab-backed toggles completedFilter and deletedFilter, so add
lines to reload them from the current tab; specifically set
completedFilter.value = Query(storage.tabs.tab()).getCompletedFilter() and
deletedFilter.value = Query(storage.tabs.tab()).getDeletedFilter() inside
_profileSet. Make the same change in setInitialTabIndex and removeTab so those
functions also restore completedFilter and deletedFilter when switching/removing
tabs (reference the completedFilter and deletedFilter Rx variables and the
Query(...).getCompletedFilter()/getDeletedFilter() accessors).

In `@lib/app/modules/home/views/filter_drawer_home_page.dart`:
- Around line 100-162: The onTap logic in the filter drawer always falls back to
filters.togglePendingFilter(), which prevents entering the completed state and
leaves waitingFilter restored but invisible; update the onTap branch in the
filter row (the one that currently calls togglePendingFilter()) to detect and
call filters.toggleCompletedFilter() when the UI should switch to completed (or
alternatively handle a waitingFilter state by exposing/toggling
filters.toggleWaitingFilter() if that exists), and ensure the Visibility/switch
block that binds filters.deletedFilter does not hide or block toggling of the
waiting/completed state—use the existing symbols
filters.toggleCompletedFilter(), filters.togglePendingFilter(),
filters.toggleDeletedFilter(), and homeController.taskReplica to decide which
toggle to call so waitingFilter cannot remain applied but invisible.

In
`@lib/app/modules/manageTaskServer/controllers/manage_task_server_controller.dart`:
- Around line 52-75: In setConfigurationFromFixtureForDebugging(), after parsing
the fixture with Taskrc.fromString(contents) you only assign trust; additionally
assign server and credentials from the parsed Taskrc (i.e. server =
taskrc.server; credentials = taskrc.credentials;) so the controller's fields
match onInit/setContent; update() remains the same and keep error handling
as-is.

---

Nitpick comments:
In
`@lib/app/modules/manageTaskServer/controllers/manage_task_server_controller.dart`:
- Line 45: Remove the leftover instructional comment marker from the assignment
"trust = taskrc.trust;" in the manage_task_server_controller.dart controller so
the line reads cleanly without the "// ⬅️ ADD THIS" suffix; locate the
assignment to the variable trust in the controller method where taskrc is used
(e.g., the controller that assigns taskrc.trust to trust) and delete only the
trailing comment text.
- Line 101: Remove the development marker comment next to the assignment "trust
= taskrc.trust;" in the ManageTaskServerController (or the controller method
where that assignment occurs); simply delete the trailing comment text "// ⬅️
ADD THIS" so the line becomes a plain assignment without any instructional
marker, leaving surrounding logic and the variable names unchanged.
- Around line 169-171: Remove the inline instructional comment after the append
line so the code reads cleanly; locate the conditional that checks `if
(trust?.isNotEmpty == true)` in the ManageTaskServerController (or the method
where `taskrcContent` is built) and delete the trailing comment `// ⬅️ ADD THIS`
from the line `taskrcContent += "\ntaskd.trust=$trust";` leaving the logic
unchanged.

In `@lib/app/utils/taskserver/taskrc.dart`:
- Line 24: Remove the development/instruction marker from the inline comment on
the variable declaration for trust: locate the line that declares var trust =
taskrc['taskd.trust']; in taskrc.dart and delete the trailing comment "// ⬅️ ADD
THIS LINE" so the code only contains the declaration (var trust =
taskrc['taskd.trust'];) with no instructional comments.
- Line 30: Remove the development marker comment trailing the property
assignment "trust: trust" (the inline comment "// ⬅️ ADD THIS LINE") so the code
only contains the property assignment; locate the "trust: trust" entry in the
taskrc.dart object/constructor and delete the instructional comment while
preserving the assignment and formatting.

In `@test/models/filters_test.dart`:
- Around line 32-67: Tests are missing assertions and invocations for the new
completedFilter and deletedFilter wiring in the Filters fixture; add checks that
completedFilter and deletedFilter initialize to the expected values and call
toggleCompletedFilter and toggleDeletedFilter to verify the callbacks flip their
booleans. Locate the Filters construction in the test (the Filters(...)
instance) and add assertions that completedFilter and deletedFilter equal the
fixture vars, then invoke toggleCompletedFilter() and toggleDeletedFilter() and
assert the corresponding completedFilter and deletedFilter values have toggled;
do the same in the other fixture block referenced (lines ~71-119) to cover both
cases.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0d6c07b0-0fb1-4ef0-b9aa-bd1636abbd40

Reviewing files that changed from the base of the PR and between f058b4a and d5a4c57.

• lib/app/models/filters.dart
• lib/app/models/tag_filters.dart
• lib/app/modules/home/controllers/home_controller.dart
• lib/app/modules/home/views/filter_drawer_home_page.dart
• lib/app/modules/manageTaskServer/controllers/manage_task_server_controller.dart
• lib/app/services/tag_filter.dart
• lib/app/utils/add_task_dialogue/date_picker_input.dart
• lib/app/utils/taskserver/taskrc.dart
• test/models/filters_test.dart