fix: taskrc parser now correctly preserves values containing '=' characters by Varadraj75 · Pull Request #612 · CCExtractor/taskwarrior-flutter · GitHub

Description

The .taskrc parser in lib/app/utils/taskserver/parse_taskrc.dart
was using line.split('=') to parse key-value pairs and blindly
extracting pair[0] and pair[1]. This caused silent data truncation
for any parameter whose value contains one or more = characters —
which is common in base64-encoded certificates and taskd parameters
with padding.

The fix replaces split('=') with indexOf('=') + substring() to
split only on the first occurrence of =, preserving the full
value including any trailing = characters.

Before (broken):

.map((line) => line.split('='))
pair[0].trim(): pair[1].trim()
// Input:  taskd.certificate=abc123==
// Stored: 'abc123'  ← trailing == silently lost

After (fixed):

line.substring(0, line.indexOf('=')).trim():
    line.substring(line.indexOf('=') + 1).trim()
// Input:  taskd.certificate=abc123==
// Stored: 'abc123=='  ✓ full value preserved

All other logic — newline splitting, comment filtering, \\/
replacement — remains identical with zero unintended side effects.

Fixes #611

Screenshots

N/A — this is a parser logic fix with no UI changes.

Checklist

Tests have been added or updated to cover the changes
Documentation has been updated to reflect the changes
Code follows the established coding style guidelines
All tests are passing

Summary by CodeRabbit

Bug Fixes
- Improved task server configuration parsing so values with equals signs, padding or other special characters are preserved correctly.
Tests
- Added regression tests to ensure complex configuration values (including those with multiple equals or trailing padding) are parsed and retained as expected.

…acters - Replace line.split('=') with indexOf('=') + substring() to split only on first occurrence of '=' - Preserves full value for base64 certificates and taskd parameters containing '=' padding characters - Fixes silent authentication failures for users with self-signed certs

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info ⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 926aea5e-e097-403d-b24a-0ac6d19244e8

📥 Commits

Reviewing files that changed from the base of the PR and between 23d863a and 65a1d70.

📒 Files selected for processing (2)

lib/app/utils/taskserver/parse_taskrc.dart
test/utils/taskserver/parse_taskrc_test.dart

🚧 Files skipped from review as they are similar to previous changes (1)

lib/app/utils/taskserver/parse_taskrc.dart

📝 Walkthrough

Walkthrough

Refactors the .taskrc parser to split each line on the first '=' occurrence (using index/substring) instead of splitting on all '=' characters, preserving values that contain '=' (e.g., base64 padding) and returning an explicitly populated map.

Changes

Cohort / File(s)	Summary
Taskrc Parser lib/app/utils/taskserver/parse_taskrc.dart	Rewrote parsing to normalize slashes, filter comments/malformed lines, find first '=' via index, and use substring-based key/value extraction with trimming; replaced expression-bodied map with an explicit result map and return.
Tests — regression additions test/utils/taskserver/parse_taskrc_test.dart	Added three regression tests ensuring values with = (base64 padding, multiple =, and values containing spaces after =) are preserved by the parser.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 I hopped through lines where equals hid in gloom,
Snipped only once, and let the whole value bloom.
No more lost padding, no silent despair,
Certificates safe with a careful hare.
Hooray for parsing done with love and care! 🥕✨

🚥 Pre-merge checks | ✅ 5 ✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and concisely describes the main fix: replacing the taskrc parser's split logic to preserve '=' characters in values.
Description check	✅ Passed	The description comprehensively explains the bug, root cause, solution with before/after code examples, and addresses all template sections including linked issue, checklist, and testing confirmation.
Linked Issues check	✅ Passed	The code changes fully implement the fix specified in #611: replacing split('=') with indexOf/substring to preserve values containing '=' characters, with regression tests confirming the solution.
Out of Scope Changes check	✅ Passed	All changes are scoped to fixing the taskrc parser and adding related regression tests; no unrelated modifications are present.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches 🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Pull request overview

This PR fixes a long-standing parser bug in parse_taskrc.dart where line.split('=') caused silent truncation of values containing = characters (e.g. base64-encoded certificates). The fix replaces the split approach with indexOf+substring to split only on the first =, preserving the full value.

Changes:

Replace split('=') with indexOf('=') + substring() to correctly handle values with embedded = characters.
Add a doc comment to the function describing the new split behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

The core bug fix is correct — using indexOf('=') instead of split('=') properly preserves values containing = characters. However, line.indexOf('=') is called twice on lines 10–11: once to compute the key's end boundary and once to compute the value's start. While the .where filter on line 8 guarantees indexOf will never return -1, calling it twice is a minor inefficiency and a maintainability concern. A local variable such as final sep = line.indexOf('=') should be introduced before the map entry to avoid the repeated call and make the intent clearer.

Fixed — indexOf('=') result is now stored in a local variable `sep` 
to avoid the double call. Regression tests added in the same commit.

The PR checklist explicitly marks "Tests have been added or updated to cover the changes" as unchecked, and the existing test file (test/utils/taskserver/parse_taskrc_test.dart) has no test case for the exact scenario this fix addresses — a value containing one or more = characters (e.g. a base64-encoded certificate like taskd.certificate=abc123==). Without such a test, a regression could silently reintroduce the original bug. A test case like:

key=value==

expecting {'key': 'value=='} should be added.

🧹 Nitpick comments (1)

lib/app/utils/taskserver/parse_taskrc.dart (1)

2-4: Add a regression test for the documented parser contract.

This behavior is critical to auth correctness; please add tests for values with multiple = (for example certificate padding) and malformed lines without =.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@lib/app/utils/taskserver/parse_taskrc.dart` around lines 2 - 4, Add a
regression test exercising the parser in parse_taskrc.dart (the parseTaskrc
function) that asserts: 1) a line like "cert=MIIC...==...==" preserves the
entire RHS including multiple '=' characters (split only on the first '='), and
2) malformed lines without '=' are handled as documented (either skipped or
produce a specific error/empty key depending on current contract). Create test
cases for both scenarios, call the parser with multi-line input including
normal, padded-certificate, and malformed entries, and assert the returned
map/structure matches the documented contract.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@lib/app/utils/taskserver/parse_taskrc.dart`:
- Around line 2-4: Add a regression test exercising the parser in
parse_taskrc.dart (the parseTaskrc function) that asserts: 1) a line like
"cert=MIIC...==...==" preserves the entire RHS including multiple '=' characters
(split only on the first '='), and 2) malformed lines without '=' are handled as
documented (either skipped or produce a specific error/empty key depending on
current contract). Create test cases for both scenarios, call the parser with
multi-line input including normal, padded-certificate, and malformed entries,
and assert the returned map/structure matches the documented contract.

ℹ️ Review info ⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7cf72e74-918a-4888-8777-d0616247f132

📥 Commits

Reviewing files that changed from the base of the PR and between 66aef29 and 23d863a.

📒 Files selected for processing (1)

lib/app/utils/taskserver/parse_taskrc.dart

- Avoid calling indexOf('=') twice by storing result in sep variable - Add 3 regression tests covering base64 padding, multiple = chars, and taskd.trust value preservation

Copilot AI review requested due to automatic review settings March 6, 2026 06:00

Copilot started reviewing on behalf of Varadraj75 March 6, 2026 06:01 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

coderabbitai Bot reviewed Mar 6, 2026

View reviewed changes

fix: store sep index in variable, add regression tests for = in values

65a1d70

- Avoid calling indexOf('=') twice by storing result in sep variable - Add 3 regression tests covering base64 padding, multiple = chars, and taskd.trust value preservation

fix: taskrc parser now correctly preserves values containing '=' characters by Varadraj75 · Pull Request #612 · CCExtractor/taskwarrior-flutter · GitHub

Uh oh!

fix: taskrc parser now correctly preserves values containing '=' characters - #612

fix: taskrc parser now correctly preserves values containing '=' characters#612
Varadraj75 wants to merge 2 commits into
CCExtractor:mainfrom
Varadraj75:fix/taskrc-parser-equals-truncation

Varadraj75 commented Mar 6, 2026 •
edited by coderabbitai Bot
Loading

Uh oh!

Uh oh!

coderabbitai Bot commented Mar 6, 2026 •
edited
Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 6, 2026

Uh oh!

Varadraj75 Mar 6, 2026

Uh oh!

Copilot AI Mar 6, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		line.substring(0, line.indexOf('=')).trim():
		line.substring(line.indexOf('=') + 1).trim(),

fix: taskrc parser now correctly preserves values containing '=' characters by Varadraj75 · Pull Request #612 · CCExtractor/taskwarrior-flutter · GitHub

Uh oh!

fix: taskrc parser now correctly preserves values containing '=' characters - #612

Conversation

Varadraj75 commented Mar 6, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Fixes #611

Screenshots

Checklist

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Varadraj75 Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Varadraj75 commented Mar 6, 2026 •
edited by coderabbitai Bot
Loading

coderabbitai Bot commented Mar 6, 2026 •
edited
Loading