fix(ios): resolve issue with running production flavor - #633
fix(ios): resolve issue with running production flavor#633Swastikmeher93 wants to merge 1 commit into
Conversation
Sorry, something went wrong.
📝 Walkthrough
WalkthroughUpdates iOS deployment target from 12.0 to 13.0 across Xcode configuration files, project settings, and plist files. Adds new build configurations (debug-production, release-production, nightly variants) with corresponding xcconfig files and scheme definitions. Introduces widget extension scheme and app links plugin registration for macOS and Windows. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem🚥 Pre-merge checks | ✅ 2 | ❌ 1 ❌ Failed checks (1 warning)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches 🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ ShareComment @coderabbitai help to get the list of available commands and usage tips. |
Sorry, something went wrong.
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (1)ios/Podfile (1)🤖 Prompt for all review comments with AI agents2-2: Consider explicitly setting the iOS platform instead of leaving it commented.
Line 2 keeps the platform unset at Podfile level. Making it explicit (platform :ios, '13.0') helps avoid Pod target drift across environments.
Proposed change🤖 Prompt for AI Agents-# platform :ios, '13.0' +platform :ios, '13.0'Verify each finding against the current code and only fix it if needed. In `@ios/Podfile` at line 2, Uncomment and explicitly set the iOS deployment target in the Podfile by restoring the platform declaration (platform :ios, '13.0') so CocoaPods resolves consistent targets across environments; locate the commented line containing "platform :ios" in the Podfile and enable it with the desired version (e.g., '13.0') to prevent Pod target drift.
Verify each finding against the current code and only fix it if needed. Inline comments: In `@ios/Flutter/Debug.xcconfig`: - Around line 1-3: Remove the unintended inclusion of the production Pods settings from the shared Debug base config: delete the include directive for "Pods-Runner.debug-production.xcconfig" in Debug.xcconfig so only "Pods-Runner.debug.xcconfig" and "Generated.xcconfig" are loaded; keep the debug-production-specific Pod configuration inside the separate Debug-production.xcconfig (ensure that "Pods-Runner.debug.xcconfig" remains included and no other production Pod includes are present). In `@ios/Flutter/Release.xcconfig`: - Around line 1-3: Remove the flavor-specific Pod includes from the shared Flutter base xcconfigs: in ios/Flutter/Release.xcconfig (and apply same change to ios/Flutter/Debug.xcconfig) delete the include of Pods-Runner.release-production.xcconfig so the file only includes the base Pods config (Pods-Runner.release.xcconfig) and Generated.xcconfig; leave the production variant includes only in ios/Runner/Release-production.xcconfig and ios/Runner/Debug-production.xcconfig. In `@ios/Runner.xcodeproj/project.pbxproj`: - Around line 62-70: The project file currently only contains PBXFileReference entries for Debug-production and Release-production xcconfig files but lacks corresponding XCBuildConfiguration entries and inclusion in each target's XCConfigurationList; create XCBuildConfiguration objects named "Debug-production", "Release-production", and "Profile-production" for every target built by the production schemes (at minimum Runner and TaskWarriorWidgetsExtension), add their buildSettings to reference the existing Pods-Runner.*-production.xcconfig files, and add those XCBuildConfiguration UUIDs into each target's XCConfigurationList so the scheme-selected configurations resolve correctly when using the production flavor. In `@ios/Runner.xcodeproj/xcshareddata/xcschemes/nightly.xcscheme`: - Around line 26-79: Update the scheme actions to use the nightly build configurations instead of production/plain ones: change TestAction's buildConfiguration from "Debug-production" to "Debug-nightly", change LaunchAction's buildConfiguration from "Debug" to "Debug-nightly", change ProfileAction's buildConfiguration from "Release-production" to "Profile-nightly", change AnalyzeAction's buildConfiguration from "Debug-production" to "Debug-nightly", and change ArchiveAction's buildConfiguration from "Release-production" to "Release-nightly" so the scheme exercises the nightly-specific settings (look for the tags TestAction, LaunchAction, ProfileAction, AnalyzeAction, ArchiveAction in the diff). --- Nitpick comments: In `@ios/Podfile`: - Line 2: Uncomment and explicitly set the iOS deployment target in the Podfile by restoring the platform declaration (platform :ios, '13.0') so CocoaPods resolves consistent targets across environments; locate the commented line containing "platform :ios" in the Podfile and enable it with the desired version (e.g., '13.0') to prevent Pod target drift.
ℹ️ Review info ⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: fd5474fa-6884-4986-a73b-e6b60853a869
📥 CommitsReviewing files that changed from the base of the PR and between f058b4a and 69870cf.
⛔ Files ignored due to path filters (2)- ios/Podfile.lock is excluded by !**/*.lock
- pubspec.lock is excluded by !**/*.lock
- ios/Flutter/AppFrameworkInfo.plist
- ios/Flutter/Debug.xcconfig
- ios/Flutter/Release.xcconfig
- ios/Podfile
- ios/Runner.xcodeproj/project.pbxproj
- ios/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme
- ios/Runner.xcodeproj/xcshareddata/xcschemes/TaskWarriorWidgetsExtension.xcscheme
- ios/Runner.xcodeproj/xcshareddata/xcschemes/dev.xcscheme
- ios/Runner.xcodeproj/xcshareddata/xcschemes/nightly.xcscheme
- ios/Runner/Debug-production.xcconfig
- ios/Runner/Info.plist
- ios/Runner/Release-production.xcconfig
- lib/app/modules/detailRoute/controllers/tags_controller.dart
- macos/Flutter/GeneratedPluginRegistrant.swift
- windows/flutter/generated_plugin_registrant.cc
Sorry, something went wrong.
| #include? "Pods/Target Support Files/Pods-Runner/Pods-Runner.debug.xcconfig" | ||
| #include? "Pods/Target Support Files/Pods-Runner/Pods-Runner.debug-production.xcconfig" | ||
| #include "Generated.xcconfig" |
There was a problem hiding this comment.
⚠️ Potential issue | 🟠 Major
🧩 Analysis chain🏁 Script executed:
cd ios && find . -name "*.xcconfig" -type f | head -20Repository: CCExtractor/taskwarrior-flutter
Length of output: 198
🏁 Script executed:
cat -n ios/Flutter/Debug.xcconfigRepository: CCExtractor/taskwarrior-flutter
Length of output: 306
🏁 Script executed:
cat -n ios/Runner/Debug-production.xcconfig 2>/dev/null || echo "File not found"Repository: CCExtractor/taskwarrior-flutter
Length of output: 301
🏁 Script executed:
cat -n ios/Runner/Debug.xcconfig 2>/dev/null || echo "File not found"Repository: CCExtractor/taskwarrior-flutter
Length of output: 89
Avoid loading production flavor Pod settings into the shared Debug base config.
Line 2 includes Pods-Runner.debug-production.xcconfig into the shared debug configuration, which causes production flavor Pod settings to contaminate normal Debug builds. The separate ios/Runner/Debug-production.xcconfig already handles debug-production-specific Pod configuration.
Proposed fix `#include`? "Pods/Target Support Files/Pods-Runner/Pods-Runner.debug.xcconfig"
-#include? "Pods/Target Support Files/Pods-Runner/Pods-Runner.debug-production.xcconfig"
`#include` "Generated.xcconfig"‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #include? "Pods/Target Support Files/Pods-Runner/Pods-Runner.debug.xcconfig" | |
| #include? "Pods/Target Support Files/Pods-Runner/Pods-Runner.debug-production.xcconfig" | |
| #include "Generated.xcconfig" | |
| `#include`? "Pods/Target Support Files/Pods-Runner/Pods-Runner.debug.xcconfig" | |
| `#include` "Generated.xcconfig" |
Verify each finding against the current code and only fix it if needed. In `@ios/Flutter/Debug.xcconfig` around lines 1 - 3, Remove the unintended inclusion of the production Pods settings from the shared Debug base config: delete the include directive for "Pods-Runner.debug-production.xcconfig" in Debug.xcconfig so only "Pods-Runner.debug.xcconfig" and "Generated.xcconfig" are loaded; keep the debug-production-specific Pod configuration inside the separate Debug-production.xcconfig (ensure that "Pods-Runner.debug.xcconfig" remains included and no other production Pod includes are present).
Sorry, something went wrong.
| #include? "Pods/Target Support Files/Pods-Runner/Pods-Runner.release.xcconfig" | ||
| #include? "Pods/Target Support Files/Pods-Runner/Pods-Runner.release-production.xcconfig" | ||
| #include "Generated.xcconfig" |
There was a problem hiding this comment.
⚠️ Potential issue | 🟠 Major
🧩 Analysis chain🏁 Script executed:
find . -type f -name "*.xcconfig" | head -20Repository: CCExtractor/taskwarrior-flutter
Length of output: 453
🏁 Script executed:
ls -la ios/Flutter/ | grep -i xcconfigRepository: CCExtractor/taskwarrior-flutter
Length of output: 202
🏁 Script executed:
ls -la ios/Runner/ | grep -i xcconfigRepository: CCExtractor/taskwarrior-flutter
Length of output: 226
🏁 Script executed:
cat ios/Flutter/Release.xcconfigRepository: CCExtractor/taskwarrior-flutter
Length of output: 275
🏁 Script executed:
cat -n ios/Runner/Release-production.xcconfig 2>/dev/null || echo "File not found"Repository: CCExtractor/taskwarrior-flutter
Length of output: 305
🏁 Script executed:
cat ios/Flutter/Debug.xcconfigRepository: CCExtractor/taskwarrior-flutter
Length of output: 271
🏁 Script executed:
cat ios/Runner/Debug-production.xcconfigRepository: CCExtractor/taskwarrior-flutter
Length of output: 280
Remove flavor-specific Pods configs from base build configs.
ios/Flutter/Release.xcconfig (and Debug.xcconfig) includes both base and production variant Pods configs. This mixes production Pod settings into non-production builds. The production variants should only be included by ios/Runner/Release-production.xcconfig and ios/Runner/Debug-production.xcconfig, which already contain them.
Proposed fixes `#include`? "Pods/Target Support Files/Pods-Runner/Pods-Runner.release.xcconfig"
-#include? "Pods/Target Support Files/Pods-Runner/Pods-Runner.release-production.xcconfig"
`#include` "Generated.xcconfig"Apply the same fix to ios/Flutter/Debug.xcconfig:
`#include`? "Pods/Target Support Files/Pods-Runner/Pods-Runner.debug.xcconfig"
-#include? "Pods/Target Support Files/Pods-Runner/Pods-Runner.debug-production.xcconfig"
`#include` "Generated.xcconfig"‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| #include? "Pods/Target Support Files/Pods-Runner/Pods-Runner.release.xcconfig" | |
| #include? "Pods/Target Support Files/Pods-Runner/Pods-Runner.release-production.xcconfig" | |
| #include "Generated.xcconfig" | |
| `#include`? "Pods/Target Support Files/Pods-Runner/Pods-Runner.release.xcconfig" | |
| `#include` "Generated.xcconfig" |
Verify each finding against the current code and only fix it if needed. In `@ios/Flutter/Release.xcconfig` around lines 1 - 3, Remove the flavor-specific Pod includes from the shared Flutter base xcconfigs: in ios/Flutter/Release.xcconfig (and apply same change to ios/Flutter/Debug.xcconfig) delete the include of Pods-Runner.release-production.xcconfig so the file only includes the base Pods config (Pods-Runner.release.xcconfig) and Generated.xcconfig; leave the production variant includes only in ios/Runner/Release-production.xcconfig and ios/Runner/Debug-production.xcconfig.
Sorry, something went wrong.
| 20B159175FD9127166652DEC /* Pods-Runner.debug-nightly.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-Runner.debug-nightly.xcconfig"; path = "Target Support Files/Pods-Runner/Pods-Runner.debug-nightly.xcconfig"; sourceTree = "<group>"; }; | ||
| 339ECB0E6A7A81221F9663F1 /* Pods_Runner.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = Pods_Runner.framework; sourceTree = BUILT_PRODUCTS_DIR; }; | ||
| 3B3967151E833CAA004F5970 /* AppFrameworkInfo.plist */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.plist.xml; name = AppFrameworkInfo.plist; path = Flutter/AppFrameworkInfo.plist; sourceTree = "<group>"; }; | ||
| 5831D6ECB3978EB8FD8D0323 /* Pods-Runner.release.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-Runner.release.xcconfig"; path = "Target Support Files/Pods-Runner/Pods-Runner.release.xcconfig"; sourceTree = "<group>"; }; | ||
| 63963AA8EF7588CFF970B1C7 /* Pods-Runner.profile-nightly.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-Runner.profile-nightly.xcconfig"; path = "Target Support Files/Pods-Runner/Pods-Runner.profile-nightly.xcconfig"; sourceTree = "<group>"; }; | ||
| 74858FAD1ED2DC5600515810 /* Runner-Bridging-Header.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = "Runner-Bridging-Header.h"; sourceTree = "<group>"; }; | ||
| 74858FAE1ED2DC5600515810 /* AppDelegate.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = AppDelegate.swift; sourceTree = "<group>"; }; | ||
| 7ACCDA4B2F71A37E0062D29B /* Debug-production.xcconfig */ = {isa = PBXFileReference; lastKnownFileType = text.xcconfig; path = "Debug-production.xcconfig"; sourceTree = "<group>"; }; | ||
| 7ACCDA4D2F71A3800062D29B /* Release-production.xcconfig */ = {isa = PBXFileReference; lastKnownFileType = text.xcconfig; path = "Release-production.xcconfig"; sourceTree = "<group>"; }; |
There was a problem hiding this comment.
⚠️ Potential issue | 🔴 Critical
Add real *-production build configurations, not just .xcconfig file refs.
Debug-production / Release-production are only represented here as file references. The project, Runner, and TaskWarriorWidgetsExtension configuration lists still expose only Debug, Release, Profile, and *-nightly, while the shared schemes already select Debug-production / Release-production. Xcode resolves scheme actions by XCBuildConfiguration name, so the production flavor is still unresolved and flutter run --flavor production will keep failing until Debug-production, Release-production, and Profile-production are added for every target built by that scheme.
Also applies to: 1158-1196
🤖 Prompt for AI AgentsVerify each finding against the current code and only fix it if needed. In `@ios/Runner.xcodeproj/project.pbxproj` around lines 62 - 70, The project file currently only contains PBXFileReference entries for Debug-production and Release-production xcconfig files but lacks corresponding XCBuildConfiguration entries and inclusion in each target's XCConfigurationList; create XCBuildConfiguration objects named "Debug-production", "Release-production", and "Profile-production" for every target built by the production schemes (at minimum Runner and TaskWarriorWidgetsExtension), add their buildSettings to reference the existing Pods-Runner.*-production.xcconfig files, and add those XCBuildConfiguration UUIDs into each target's XCConfigurationList so the scheme-selected configurations resolve correctly when using the production flavor.
Sorry, something went wrong.
| <TestAction | ||
| buildConfiguration = "Debug-production" | ||
| selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB" | ||
| selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB" | ||
| customLLDBInitFile = "$(SRCROOT)/Flutter/ephemeral/flutter_lldbinit" | ||
| shouldUseLaunchSchemeArgsEnv = "YES" | ||
| shouldAutocreateTestPlan = "YES"> | ||
| </TestAction> | ||
| <LaunchAction | ||
| buildConfiguration = "Debug" | ||
| selectedDebuggerIdentifier = "Xcode.DebuggerFoundation.Debugger.LLDB" | ||
| selectedLauncherIdentifier = "Xcode.DebuggerFoundation.Launcher.LLDB" | ||
| customLLDBInitFile = "$(SRCROOT)/Flutter/ephemeral/flutter_lldbinit" | ||
| launchStyle = "0" | ||
| useCustomWorkingDirectory = "NO" | ||
| ignoresPersistentStateOnLaunch = "NO" | ||
| debugDocumentVersioning = "YES" | ||
| debugServiceExtension = "internal" | ||
| allowLocationSimulation = "YES"> | ||
| <BuildableProductRunnable | ||
| runnableDebuggingMode = "0"> | ||
| <BuildableReference | ||
| BuildableIdentifier = "primary" | ||
| BlueprintIdentifier = "97C146ED1CF9000F007C117D" | ||
| BuildableName = "Runner.app" | ||
| BlueprintName = "Runner" | ||
| ReferencedContainer = "container:Runner.xcodeproj"> | ||
| </BuildableReference> | ||
| </BuildableProductRunnable> | ||
| </LaunchAction> | ||
| <ProfileAction | ||
| buildConfiguration = "Release-production" | ||
| shouldUseLaunchSchemeArgsEnv = "YES" | ||
| savedToolIdentifier = "" | ||
| useCustomWorkingDirectory = "NO" | ||
| debugDocumentVersioning = "YES"> | ||
| <BuildableProductRunnable | ||
| runnableDebuggingMode = "0"> | ||
| <BuildableReference | ||
| BuildableIdentifier = "primary" | ||
| BlueprintIdentifier = "97C146ED1CF9000F007C117D" | ||
| BuildableName = "Runner.app" | ||
| BlueprintName = "Runner" | ||
| ReferencedContainer = "container:Runner.xcodeproj"> | ||
| </BuildableReference> | ||
| </BuildableProductRunnable> | ||
| </ProfileAction> | ||
| <AnalyzeAction | ||
| buildConfiguration = "Debug-production"> | ||
| </AnalyzeAction> | ||
| <ArchiveAction | ||
| buildConfiguration = "Release-production" | ||
| revealArchiveInOrganizer = "YES"> | ||
| </ArchiveAction> |
There was a problem hiding this comment.
⚠️ Potential issue | 🟠 Major
Point the nightly scheme at the nightly build configs.
This scheme never selects Debug-nightly / Profile-nightly / Release-nightly, even though those configurations are added in ios/Runner.xcodeproj/project.pbxproj. Right now Line 35 launches plain Debug, and the other actions point to *-production, so the nightly scheme will not exercise nightly-specific settings at all.
Suggested mapping- buildConfiguration = "Debug-production"
+ buildConfiguration = "Debug-nightly"
- buildConfiguration = "Debug"
+ buildConfiguration = "Debug-nightly"
- buildConfiguration = "Release-production"
+ buildConfiguration = "Profile-nightly"
- buildConfiguration = "Debug-production"
+ buildConfiguration = "Debug-nightly"
- buildConfiguration = "Release-production"
+ buildConfiguration = "Release-nightly"Verify each finding against the current code and only fix it if needed. In `@ios/Runner.xcodeproj/xcshareddata/xcschemes/nightly.xcscheme` around lines 26 - 79, Update the scheme actions to use the nightly build configurations instead of production/plain ones: change TestAction's buildConfiguration from "Debug-production" to "Debug-nightly", change LaunchAction's buildConfiguration from "Debug" to "Debug-nightly", change ProfileAction's buildConfiguration from "Release-production" to "Profile-nightly", change AnalyzeAction's buildConfiguration from "Debug-production" to "Debug-nightly", and change ArchiveAction's buildConfiguration from "Release-production" to "Release-nightly" so the scheme exercises the nightly-specific settings (look for the tags TestAction, LaunchAction, ProfileAction, AnalyzeAction, ArchiveAction in the diff).
Sorry, something went wrong.
Reviewers
At least 1 approving review is required to merge this pull request.
🐛 Problem
The Flutter app failed to run on iOS devices due to incorrect flavor configuration and missing iOS build files (xcfilelist).
🎯 Goal
Enable successful build and execution of the app on iOS devices.
✅ Solution
Fixed the iOS project configuration and resolved CocoaPods-related issues that were preventing the app from running.
🔧 Changes Made
🧪 How to Test
📌 Result
The app now builds and runs successfully on iOS devices.
Summary by CodeRabbit
Release Notes
New Features
Chores