| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
The tc_helper native libraries (Android jniLibs *.so and the iOS tc_helper.xcframework) are build outputs of the rust/ crate, not source. Committing them across history bloated the repository to 100MB+ on clone. Remove them from the tree, git-ignore both output paths, and document and script how to regenerate them for Android (cargo-ndk) and iOS (xcframework build via build_ios.sh). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
📝 Walkthrough
WalkthroughThis PR transitions Rust native library builds from pre-built xcframework and JNI artifacts to local generation via automated scripts. Git configuration now excludes generated outputs, the README documents required build steps and output directories, and new Bash scripts automate Android and iOS compilation. ChangesNative Build Automation and Artifact Management
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Poem🚥 Pre-merge checks | ✅ 5 ✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches 🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ ShareComment @coderabbitai help to get the list of available commands and usage tips. |
Sorry, something went wrong.
There was a problem hiding this comment.
rust/README.md (1)🤖 Prompt for all review comments with AI agents23-27: 💤 Low value
Clarify working directory for the manual cargo command.
The cargo ndk command at line 26 uses a relative path (../android/app/src/main/jniLibs) that assumes execution from the rust/ directory, but this isn't explicitly stated. Users might run it from the repository root and get an incorrect output path.
📝 Suggested documentation improvement🤖 Prompt for AI AgentsRequires [`cargo-ndk`](https://github.com/bbqsrc/cargo-ndk) and the Android NDK. +From the `rust/` directory: + ```bash cargo ndk -t arm64-v8a -t armeabi-v7a -o ../android/app/src/main/jniLibs build --releaseVerify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@rust/README.md` around lines 23 - 27, The README's cargo ndk example uses a relative output path that assumes you run the command from the rust/ directory; update the README to explicitly state the required working directory (e.g., "run this from the rust/ directory") or provide an alternative command using an absolute or repo-root-aware path so the cargo ndk -t arm64-v8a -t armeabi-v7a -o ../android/app/src/main/jniLibs build --release example will consistently place libraries in the intended android/app/src/main/jniLibs location; reference the shown cargo ndk command in the README to locate where to add the clarification.
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. Nitpick comments: In `@rust/README.md`: - Around line 23-27: The README's cargo ndk example uses a relative output path that assumes you run the command from the rust/ directory; update the README to explicitly state the required working directory (e.g., "run this from the rust/ directory") or provide an alternative command using an absolute or repo-root-aware path so the cargo ndk -t arm64-v8a -t armeabi-v7a -o ../android/app/src/main/jniLibs build --release example will consistently place libraries in the intended android/app/src/main/jniLibs location; reference the shown cargo ndk command in the README to locate where to add the clarification.
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 6d48c1f7-5770-4f8d-abb8-8ef748e4962b
📥 CommitsReviewing files that changed from the base of the PR and between f058b4a and 63774f5.
⛔ Files ignored due to path filters (4)
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Summary
The tc_helper native libraries are build outputs of the rust/ crate, but
they were checked into git. That bloated the repo to 100MB+ on clone
(.git ~129MB). This PR stops tracking them and documents how to regenerate
them instead.
Addresses Part 1 of #647.
What this does
slice) via cargo build + lipo + xcodebuild -create-xcframework. iOS
builds were previously undocumented.
How to build the native libs after pulling this
Note on existing clone size
This PR only stops future bloat — the old blobs remain in history until a
maintainer rewrites it (force-push). The recommended git filter-repo
procedure and its caveats are written up in #647, and is best run right after
this merges.
Verification
bash -n.
(the iOS framework layout matches the previously committed
tc_helper.xcframework: dynamic framework, @rpath install name, bundle id
com.ccextractor.taskwarriorflutter.tc-helper, min iOS 13.0). I did not
have the Android NDK / Xcode toolchain available to run a full native build —
please verify a clean Android + iOS build before merging.
Test plan
Summary by CodeRabbit
Documentation
Chores