Update the documentation, and add a developer docker-compose - #47
Merged
msm-code merged 4 commits intoApr 6, 2020
Merged
msm-code merged 4 commits into
msm-code merged 4 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
msm-code
force-pushed
the
feature/documentation
branch
from
c2f93a1 to
6e036bd
Compare
April 5, 2020 22:24
nazywam
reviewed
Apr 5, 2020
Comment thread
CONTRIBUTING.md
Outdated
Comment thread
docs/internals.md
Outdated
Comment thread
docs/internals.md
Outdated
msm-code
force-pushed
the
feature/documentation
branch
2 times, most recently
from
544dc06 to
29e6f46
Compare
April 5, 2020 23:05
msm-code
force-pushed
the
feature/documentation
branch
from
29e6f46 to
0a8d8a4
Compare
April 5, 2020 23:06
ITAYC0HEN
reviewed
Apr 6, 2020
Comment thread
README.md
ITAYC0HEN
suggested changes
Apr 6, 2020
ITAYC0HEN
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Good work! :)
Sorry, something went wrong.
Comment thread
README.md
Outdated
Comment thread
README.md
Outdated
Comment thread
INSTALL.md
Outdated
Comment thread
README.md
Outdated
Comment thread
README.md
Outdated
Comment thread
INSTALL.md
Outdated
Comment thread
INSTALL.md
Comment thread
INSTALL.md
Outdated
Comment thread
INSTALL.md
Outdated
Comment thread
src/app.py
Co-Authored-By: Itay Cohen <itaycohen23@gmail.com>
Co-Authored-By: Itay Cohen <itaycohen23@gmail.com>
ITAYC0HEN
approved these changes
Apr 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major rewrite of the documentation.
The original goal was to add a short instruction for new contributors, but it kinda went out of control.
I've also noticed many problems with the workflow while describing it, so I've changed the recommended developer environment to docker-compose.yml.
Fixes #31.