FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: webui 支持 pnpm 以及环境变量 by 13982720426 · Pull Request #407 · CJackHwang/ds2api · GitHub

This repository was archived by the owner on May 13, 2026. It is now read-only.
/ ds2api Public archive

feat: webui 支持 pnpm 以及环境变量 - #407

Open
13982720426 wants to merge 4 commits into
CJackHwang:devfrom
13982720426:webui
ConversationCommits (4)ChecksFiles changed
Open

feat: webui 支持 pnpm 以及环境变量#407
13982720426 wants to merge 4 commits into
CJackHwang:devfrom
13982720426:webui

Conversation

13982720426 commented May 2, 2026

Copy link
Copy Markdown

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • 📝 docs
  • 🔨 chore

🔀 变更说明 | Description of Change

webui 支持 pnpm 方式
webui 支持环境变量，无需启动本地后端直接配置线上后端地址
更新相关文档

📝 补充信息 | Additional Information

合并了主分支重新提交

jackhoo added 3 commits May 2, 2026 01:51
feat(webui): support VITE_API_BASE_URL for configurable dev proxy target
352fad3 
Allow the Vite dev server proxy target to be set via environment variable
instead of hardcoding localhost:5001. Also add pnpm-lock.yaml and .env.example.
docs: add npm/pnpm dual usage examples across documentation
4312179 
Document both npm (with --prefix from repo root) and pnpm (cd webui)
command variants in README, DEVELOPMENT, CONTRIBUTING, DEPLOY, and
TESTING docs. Clarify that pnpm does not support --prefix.
Merge branch 'main' into webui
0886659

vercel Bot commented May 2, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the cjack's projects Team on Vercel.

A member of the Team first needs to authorize it.

vercel Bot commented May 2, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ds2api Ready Preview, Comment May 2, 2026 2:09pm

CJackHwang changed the base branch from main to dev May 2, 2026 14:09

CJackHwang commented May 2, 2026

Copy link
Copy Markdown
Owner

以后开发提交改动都按dev分支走吧

13982720426 commented May 2, 2026

Copy link
Copy Markdown
Author

以后开发提交改动都按dev分支走吧

也行

NgoQuocViet2001 commented May 2, 2026

Copy link
Copy Markdown
Contributor

看了一下这版 WebUI env 支持，整体 CI 是绿的。有两个小点可以考虑顺手收一下，非阻塞：

  1. webui/.env 现在被提交进来了，但仓库 .gitignore 已经忽略 .env，而文档语义也是让本地开发者按需创建自己的 .env。建议只保留 webui/.env.example，避免后续本地代理地址改动被误提交。
  2. 本地跑 git diff --check upstream/dev...HEAD 会看到几处 trailing whitespace，例如 README.MD、docs/DEVELOPMENT.md、docs/TESTING.md 里的新增命令行。

如果去掉 tracked .env 并清掉这些空格，后续维护会更干净一些。

chore: remove tracked webui/.env and fix trailing whitespace in docs
e7d1502 
- Remove webui/.env from Git tracking; .env is already gitignored and
  developers should create their own from .env.example
- Strip trailing whitespace from README.MD, docs/DEVELOPMENT.md,
  docs/TESTING.md

NgoQuocViet2001 commented May 2, 2026

Copy link
Copy Markdown
Contributor

看了最新的 e7d1502，前面两个非阻塞点已经收掉了：

  • webui/.env 已移出 Git tracking，现在只保留 webui/.env.example
  • 本地跑 git diff --check upstream/dev...upstream/pr/407 已经没有 trailing whitespace 报错

我也本地验证了：

npm ci --prefix webui
npm run build --prefix webui

两条都通过。当前 PR 上剩下的红色状态是 Vercel 对新 commit 的 “Authorization required to deploy”，看起来是需要 Team member 授权预览部署，不是代码或 WebUI build 失败。

This was referenced May 5, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL