FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix deploy_docs action by zachcran · Pull Request #26 · CMakePP/.github · GitHub

Repository navigation

Fix deploy_docs action - #26

Merged
ryanmrichard merged 2 commits into
mainfrom
fix_deploy_docs
Jul 19, 2023
Merged

ryanmrichard merged 2 commits into
mainfrom
fix_deploy_docs

Conversation

zachcran commented Jul 18, 2023 •
edited
Loading

Copy link
Copy Markdown

Is this pull request associated with an issue(s)?
Attempts to fix CMakePPLang issue 93.

Description
The deploy_docs workflow does not seem to be triggering on pull requests, and it is skipped when it is manually triggered. This PR will attempt to fix those issues so our documentation website is generated properly.

TODOs

  • I suspect that the workflow is skipped when manually triggered because of the if: github.event.pull_request.merged == true line, since there isn't a pull request being merged. This should be fixed by saying "if the event is the workflow being triggered manually OR a pull request was merged, run the workflow".
  • Figure out why it is not triggering on PRs. This will probably actually be solved in a later PR if this one is merged and the fix doesn't stick.

zachcran self-assigned this Jul 18, 2023
zachcran added the bump:patch Increments the patch version. label Jul 18, 2023
zachcran changed the title Make deploy_docs action trigger if event is not PR as well Fix deploy_docs action Jul 18, 2023
zachcran requested a review from ryanmrichard July 18, 2023 22:51
zachcran marked this pull request as ready for review July 18, 2023 22:51
ryanmrichard merged commit 643b765 into main Jul 19, 2023
ryanmrichard deleted the fix_deploy_docs branch July 19, 2023 03:04

Copy link
Copy Markdown

🚀 [bumpr] Bumped! New version:v0.0.3 Changes:v0.0.2...v0.0.3

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bump:patch Increments the patch version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL