fix(copilot): add missing custom_path param to save_credentials - #68
Open
marcobazzani wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
DeviceCodeFlow (and other OAuth flows) call provider.save_credentials with two positional arguments — credentials and save_path — matching the signature of ClaudeOAuthProvider and CodexOAuthProvider. CopilotOAuthProvider only accepted one positional argument, causing: TypeError: CopilotOAuthProvider.save_credentials() takes 2 positional arguments but 3 were given This was introduced in commit 9e44f24 which added --file / custom save-path support to the OAuth flows but forgot to update the Copilot provider to match the new interface. Fix: add custom_path: Any | None = None to the signature for interface compatibility. The Copilot provider ignores the value (it always writes to its own storage) — the parameter is purely a protocol alignment fix.
Copy link
Copy Markdown
Author
|
so ? will you merge it ? |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #67
Problem
DeviceCodeFlow.run() (and other OAuth flows) call provider.save_credentials(credentials, save_path) with two arguments. ClaudeOAuthProvider and CodexOAuthProvider both accept custom_path: Any | None = None, but CopilotOAuthProvider.save_credentials() only accepted one positional argument, causing:
This broke ccproxy auth login copilot entirely on v0.2.10.
Fix
Add custom_path: Any | None = None to CopilotOAuthProvider.save_credentials() for interface compatibility. The Copilot provider ignores the value (it always writes to its own storage) — this is purely a signature alignment fix.
How it was introduced
Commit 9e44f249 added --file / custom save-path support to the OAuth flows and updated the Claude and Codex providers but missed the Copilot provider.