| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
hey @greptileai, please re-review the PR |
Sorry, something went wrong.
|
hey @greptileai, please re-review the PR |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Windows exports read progress and logs from a separate worker. The existing Windows pipes expose asynchronous handles to a synchronous reader, which can cause Rust to terminate the desktop process when a read has not completed.
Use synchronous pipes for export-worker output on Windows and close the parent’s writer handles immediately after spawn so worker exit produces EOF. Other platforms retain their existing pipe behavior. The export protocol and recording format are unchanged.
Verification
Verified commit: 9e1e6b34eb95300c1d5e615168264f87dba73d1f.
Demo and remaining validation
This internal process-I/O change has no distinct visual state. Native handle-mode and subprocess assertions provide direct evidence of the changed behavior; a screen recording would not establish whether the handles are synchronous.
Not yet verified by hand: a full export with the rebuilt Windows application. The original crash has not been reproduced, and the exact caller stack is unavailable. Physical GPU behavior and release packaging/signing remain unverified. No database or schema change is required.
The PR appears safe to merge based on the reviewed changes; the full rebuilt-Windows-application export remains the author's stated validation gate.
Summary
The PR routes export-worker spawning through a shared helper that supplies synchronous stdout and stderr pipes on Windows and retains piped output on other platforms.
Reviews (3) · Last reviewed commit: "Merge branch 'main' into building/window..."