| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
hey @greptileai, please re-review the PR |
Sorry, something went wrong.
|
hey @greptileai, please re-review the PR |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Summary
Remove the two diagnostic println! calls in general-settings initialization. A closed stdout pipe makes these otherwise harmless startup messages panic before initialization can finish.
The same startup path had two more console writes, which now go through tracing like the rest of startup logging:
The tracing console layer reports a failed stdout write on stderr instead of panicking, and these messages now also reach the log file. Settings loading, persistence, migrations, telemetry configuration, muxer registration, notification permission behavior, and existing error logging are unchanged. Remaining println! calls in the desktop crate run only from user actions (clipboard, screenshot upload, plan check) or debug builds, not during startup.
Verification
Rust formatting and whitespace checks passed.
A local Linux regression harness compiles the production init function verbatim with synthetic in-memory settings dependencies. All 10 cases passed across open/closed stdout, existing/missing/malformed settings, completed migrations, and save errors. The pre-change function reproduced the broken-pipe panic in all five closed-stdout cases.
Three successful-initialization cases also passed with both stdout and stderr connected to a pipe with no reader. A separate late-close case reproduced the old final-message panic after settings save and passed with this change.
The isolated regression harness passed Clippy with warnings denied. It is local test evidence, not a full native app test.
Full cargo check --locked -p cap-desktop was attempted but stopped in the existing alsa-sys dependency because the Linux environment lacks alsa.pc. Native app startup and macOS/Windows runtime behavior have not been tested locally.
CI run 9105 passed for 1473b350286ae155f0a0d90ff404fe20f67ac61c: all three desktop build/test jobs (Linux, macOS, Windows), both workspace Clippy jobs, Typecheck, Mobile, and formatting checks. Vercel also passed. Conditional Rust-cache and Tauri-plugin-version jobs were skipped as expected.
Follow-up commits: cargo clippy -p cap-desktop --all-targets -- -D warnings and cargo fmt --check passed locally on macOS.
No configuration, dependency, generated binding, or migration changes.
The PR appears safe to merge based on the reviewed changes.
Summary
The PR removes two settings-initialization stdout writes and routes startup hotkey and notification diagnostics through tracing.
Reviews (3) · Last reviewed commit: "fix(desktop): log hotkey store load fail..."