fix(desktop): skip app handle in transcribe_audio instrumentation and downgrade chunk logging (#2367) - #2415
Open
adamscarmccoy-boop wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
… downgrade chunk logging (CapSoftware#2367) Resolves CapSoftware#2367. /claim CapSoftware#2367 - Add skip(app) to #[instrument] on transcribe_audio to eliminate 9KB Tauri AppHandle dump on every event - Downgrade per-chunk resampling logs from info to debug to eliminate hundreds of repetitive log lines - Reduces transcription log size by ~96% Signed-off-by: adamscarmccoy-boop <adamscarmccoy@gmail.com>
Copy link
Copy Markdown
|
🚨 Contributor flagged. Click here for more info: Superagent Dashboard |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Hey @mc-ilroy its AdamScarMcCoy here, saw your merges are active and wanted to advise that this merge has completed the required checks and is ready to go!! Let me know if I can help in any other way, look forward to your review. Thanks! |
Sorry, something went wrong.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2367. /claim #2367
Description
In \ ranscribe_audio, the #[instrument]\ attribute did not specify \skip(app). Because \AppHandle\ implements \Debug, every tracing event printed the full internal Tauri \AppHandle\ state (~9 KB per log entry). In addition, per-chunk audio resampling logged at \INFO\ level every 100 chunks, resulting in over 800 log lines and ballooning single-transcription logs to ~7.7 MB.
Changes
The PR appears safe to merge; no actionable regression was identified.
Summary
The PR excludes the verbose Tauri app handle from the transcription span and moves per-chunk resampling messages to debug level while retaining higher-level extraction and error logs.
Reviews (1) · Last reviewed commit: "fix(desktop): skip app handle in transcr..."