FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Ship kernels.sqlite that was previously excluded by jimgao1 · Pull Request #9 · CentML/DeepView.Predict · GitHub

This repository was archived by the owner on May 27, 2026. It is now read-only.
/ DeepView.Predict Public archive

Ship kernels.sqlite that was previously excluded - #9

Merged
jimgao1 merged 2 commits into
mainfrom
nov04-fix-kernels-sqlite
Nov 7, 2022
ConversationCommits (2)ChecksFiles changed
Merged

Ship kernels.sqlite that was previously excluded#9
jimgao1 merged 2 commits into
mainfrom
nov04-fix-kernels-sqlite

Conversation

jimgao1 commented Nov 5, 2022

Copy link
Copy Markdown
Contributor

No description provided.

jimgao1 requested a review from anurlybayev November 5, 2022 01:50

anurlybayev commented Nov 7, 2022

Copy link
Copy Markdown
Contributor

@jimgao1 can you elaborate on what this will allow us to do? Maybe provide a historical context on why we excluded it and why we needed it now?

jimgao1 commented Nov 7, 2022

Copy link
Copy Markdown
Contributor Author

@jimgao1 can you elaborate on what this will allow us to do? Maybe provide a historical context on why we excluded it and why we needed it now?

This file contains the number of registers used for each kernel launched. This information is used during wave scaling.

We have simply overlooked this file in the past, since all the testing was done by using the extract_models.sh mechanism instead of git LFS.

anurlybayev approved these changes Nov 7, 2022
View reviewed changes

anurlybayev left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ship it!

jimgao1 merged commit 1b96ed7 into main Nov 7, 2022
michaelshin deleted the nov04-fix-kernels-sqlite branch May 1, 2023 19:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

michaelshin Awaiting requested review from michaelshin
1 more reviewer
anurlybayev anurlybayev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL