FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[Feature] Επιλογή σταθμού σε περισσότερες θέσεις από 9 by kyriakosschwarz · Pull Request #113 · CerebruxCode/shelldio · GitHub

[Feature] Επιλογή σταθμού σε περισσότερες θέσεις από 9 - #113

Open
kyriakosschwarz wants to merge 6 commits into
CerebruxCode:stablefrom
kyriakosschwarz:number_param
Open

[Feature] Επιλογή σταθμού σε περισσότερες θέσεις από 9#113
kyriakosschwarz wants to merge 6 commits into
CerebruxCode:stablefrom
kyriakosschwarz:number_param

Conversation

Copy link
Copy Markdown

The integer shell parameter now can be arbitrarily large. Previously 1-9.

zoispag left a comment
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It was originally supposed to be a "quick start" feature, which explains the 1-9 implementation. Nevertheless, I am totally in favor of such a change, as long as it is working correctly. 👍🏼

+([1-9])) does not take zeros into account, so shelldio 10 will lead to "wrong selection" response.

By the way, we also need to make sure that extended glob (shopt -s extglob) is available on all platforms, including different Linux flavors and macOS.

Comment thread shelldio.sh
while [ "$1" != "" ]; do
case $1 in
[1-9])
+([1-9]))

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What about 10, 20, 30 etc?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Στην δοκιμή μου, έβαλα 15 αγαπημένα. έτρεξα shelldio 14 και έβγαλε Λάθος επιλογή

Copy link
Copy Markdown

Δοκιμές:

  1. Όταν δεν έχεις λίστα με αγαπημένα (δεν υπάρχει αρχείο ~/.shelldio/my_stations.txt) τότε το Shelldio μπορείς να το τρέξεις με όποιον αριθμό θες πχ. shelldio 135
  2. Όταν όμως έχεις λίστα με αγαπημένα π.χ. έχεις 20 σταθμούς, δεν μπορείς να επιλέξεις αριθμό πάνω από 10.

Άρα η λύση που προτείνει ο @kyriakosschwarz δουλεύει μια χαρά αρκεί να μην έχεις αγαπημένη λίστα. Οπότε δεν μπορεί να γίνει ακόμα merge μέχρι να γίνει η απαραίτητη διόρθωση.

cerebrux changed the title Arbitrarily large integer parameter [Feature] Επιλογή σταθμού σε περισσότερες θέσεις από 9 Jan 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL