Migrate nan.h inclusions and binding.gyp to node-addon-api - #1
yumin-chen wants to merge 2 commits into
Conversation
Sorry, something went wrong.
Co-authored-by: yumin-chen <10954839+yumin-chen@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back! New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Sorry, something went wrong.
Co-authored-by: yumin-chen <10954839+yumin-chen@users.noreply.github.com>
Updated binding.gyp template and C++ headers/sources across generate/templates to include napi.h instead of nan.h, and provided a comprehensive migration guide for transitioning NodeGit from NAN to Node-API.
PR created automatically by Jules for task 1478154876853610351 started by @yumin-chen