Fix npm install and native C++ build errors - #18
yumin-chen wants to merge 7 commits into
Conversation
Sorry, something went wrong.
Require node >= 22 and use NAPI_VERSION=10
- Fix persistentStorage constructor initialization in AsyncWorker template - Add OpenSSL 1.1.0+ guards for deprecated locking callbacks in nodegit.cc - Split duplicate NodeGitWrapper destructor into DestroyNative - Add null/undefined checks in SetNativeOwners and convert_to_v8.cc - Suppress destructors on persistent references to prevent N-API invalid_arg errors during teardown - Add optional krb5-config check in gyp binding files - Add emnapi, napi-rs-ts, and node-addon-examples submodules
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back! New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Sorry, something went wrong.
- Fix persistentStorage constructor initialization in AsyncWorker template - Add OpenSSL 1.1.0+ guards for deprecated locking callbacks in nodegit.cc - Split duplicate NodeGitWrapper destructor into DestroyNative - Add null/undefined checks in SetNativeOwners and convert_to_v8.cc - Suppress destructors on persistent references to prevent N-API invalid_arg errors during teardown - Add optional krb5-config check in gyp binding files - Add emnapi, napi-rs-ts, and node-addon-examples submodules
Fixed npm install and native compilation issues for nodegit on Node.js v22/v24 with N-API, resolved runtime N-API reference teardown errors, updated build gyp files, and added requested packages/emnapi submodules.
PR created automatically by Jules for task 11478420950730889326 started by @yumin-chen