FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

add emnapi submodules and emnapi dependency by yumin-chen · Pull Request #19 · Chen-Software/nodegit · GitHub

Repository navigation

add emnapi submodules and emnapi dependency - #19

Draft
yumin-chen wants to merge 5 commits into
mainfrom
jules-13221936085141531536-5fa1ffd0
Draft

yumin-chen wants to merge 5 commits into
mainfrom
jules-13221936085141531536-5fa1ffd0

Conversation

Copy link
Copy Markdown

Added emnapi, napi-rs-ts, and node-addon-examples git submodules and installed emnapi as a local package dependency. Provide detailed architectural explanation on supporting both native and WASM target builds for NodeGit using emnapi.


PR created automatically by Jules for task 13221936085141531536 started by @yumin-chen

Added `packages/emnapi`, `packages/napi-rs-ts`, and `packages/node-addon-examples` as git submodules and installed `emnapi` as a package dependency.

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

- Added `packages/emnapi`, `packages/napi-rs-ts`, and `packages/node-addon-examples` submodules.
- Installed `emnapi` local dependency in `package.json`.
- Updated `binding.gyp` template with Emscripten and WASI compilation settings.
- Added `build:wasm:emscripten` and `build:wasm:wasi` npm build scripts.

Copy link
Copy Markdown
Author

Do you have WASI_SDK in your env? If not, please install it with below so you can build using WASI_SDK:

WASI_OS=linux
WASI_ARCH=x86_64 # or 'arm64' if running on arm64 host
WASI_VERSION=34
WASI_VERSION_FULL=${WASI_VERSION}.0
wget https://github.com/WebAssembly/wasi-sdk/releases/download/wasi-sdk-${WASI_VERSION}/wasi-sdk-${WASI_VERSION_FULL}-${WASI_ARCH}-${WASI_OS}.tar.gz
tar xvf wasi-sdk-${WASI_VERSION_FULL}-${WASI_ARCH}-${WASI_OS}.tar.gz

Copy link
Copy Markdown

Do you have WASI_SDK in your env? If not, please install it with below so you can build using WASI_SDK:

WASI_OS=linux
WASI_ARCH=x86_64 # or 'arm64' if running on arm64 host
WASI_VERSION=34
WASI_VERSION_FULL=${WASI_VERSION}.0
wget https://github.com/WebAssembly/wasi-sdk/releases/download/wasi-sdk-${WASI_VERSION}/wasi-sdk-${WASI_VERSION_FULL}-${WASI_ARCH}-${WASI_OS}.tar.gz
tar xvf wasi-sdk-${WASI_VERSION_FULL}-${WASI_ARCH}-${WASI_OS}.tar.gz

Thank you! I have downloaded and configured WASI_SDK version 34 at /opt/wasi-sdk. WASI_SDK_PATH can now be set to /opt/wasi-sdk for WASI builds.

…port

- Added emnapi, napi-rs-ts, and node-addon-examples submodules.
- Configured emnapi dependency in package.json.
- Updated binding.gyp template for Emscripten and WASI targets.
- Installed WASI_SDK v34 at /opt/wasi-sdk.
Created `wit/nodegit.wit` defining the Wasm Interface Type (WIT) IDL for NodeGit WASI component exports and imports.
….wit IDL

- Added emnapi, napi-rs-ts, and node-addon-examples git submodules.
- Installed emnapi dependency in package.json.
- Configured binding.gyp template for emscripten and wasi build targets.
- Installed WASI_SDK v34 at /opt/wasi-sdk and linked /app/wasi-sdk-34.0.
- Added wit/nodegit.wit IDL definition for NodeGit WASI Component Model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL