Fix Node-API build configuration and C++ helper template overloads - #2
yumin-chen wants to merge 8 commits into
Conversation
Sorry, something went wrong.
- Add NODE_ADDON_API_CPP_EXCEPTIONS define and -fexceptions flag in binding.gyp - Fix ToV8 overload template ambiguity in v8_helpers.h for LP64 systems - Add missing <cassert> include in tracker_wrap.cc - Fix invalid assert methods in clone.js tests Co-authored-by: yumin-chen <10954839+yumin-chen@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back! New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Sorry, something went wrong.
- Add NODE_ADDON_API_CPP_EXCEPTIONS define and -fexceptions flag in binding.gyp - Fix ToV8 overload template ambiguity in v8_helpers.h for LP64 systems - Add missing <cassert> include in tracker_wrap.cc - Fix invalid assert methods in clone.js tests Co-authored-by: yumin-chen <10954839+yumin-chen@users.noreply.github.com>
- Add NODE_ADDON_API_CPP_EXCEPTIONS define and -fexceptions flag in binding.gyp - Fix ToV8 overload template ambiguity in v8_helpers.h for LP64 systems - Add missing <cassert> include in tracker_wrap.cc - Fix invalid assert methods in clone.js tests Co-authored-by: yumin-chen <10954839+yumin-chen@users.noreply.github.com>
Fixed build configuration and C++ helper templates for node-addon-api compilation on Linux and updated test assertion methods.
PR created automatically by Jules for task 12190066570454896837 started by @yumin-chen