Fix C++ compilation and recompile native module - #3
yumin-chen wants to merge 7 commits into
Conversation
Sorry, something went wrong.
- Add missing <cassert> include in tracker_wrap.cc templates and generated files - Remove duplicate ToV8 overloads in v8_helpers.h to fix int64_t redefinition errors on 64-bit systems - Add NAPI_DISABLE_CPP_EXCEPTIONS define to binding.gyp - Generate native C++ code and recompile native module successfully Co-authored-by: yumin-chen <10954839+yumin-chen@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back! New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Sorry, something went wrong.
- Add missing <cassert> include in tracker_wrap.cc templates and generated files - Remove duplicate ToV8 overloads in v8_helpers.h to fix int64_t redefinition errors on 64-bit systems - Add NAPI_DISABLE_CPP_EXCEPTIONS define to binding.gyp - Generate native C++ code and recompile native module successfully Co-authored-by: yumin-chen <10954839+yumin-chen@users.noreply.github.com>
Fix C++ native compilation errors during npm run recompile by updating template files (v8_helpers.h, tracker_wrap.cc, binding.gyp), running npm run generateNativeCode, and ensuring the native C++ module compiles cleanly.
PR created automatically by Jules for task 9638741007228167789 started by @yumin-chen