FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix native build templates and C++ compilation issues by yumin-chen · Pull Request #5 · Chen-Software/nodegit · GitHub

Repository navigation

Fix native build templates and C++ compilation issues - #5

Open
yumin-chen wants to merge 7 commits into
napifrom
jules-3891411351903239790-e167c447
Open

yumin-chen wants to merge 7 commits into
napifrom
jules-3891411351903239790-e167c447

Conversation

Copy link
Copy Markdown

Resolved build issues by:

  1. Updating generate/templates/templates/binding.gyp to enable C++ exception flags (NAPI_CPP_EXCEPTIONS) and un-suppress -fno-exceptions for node-addon-api.
  2. Updating generate/templates/manual/include/v8_helpers.h to use template SFINAE for arithmetic types in ToV8, eliminating integer type redefinition collisions on Linux 64-bit systems.
  3. Adding #include <cassert> in generate/templates/manual/src/tracker_wrap.cc.
  4. Successfully generated native code and recompiled the native bindings.

PR created automatically by Jules for task 3891411351903239790 started by @yumin-chen

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Co-authored-by: yumin-chen <10954839+yumin-chen@users.noreply.github.com>
yumin-chen force-pushed the napi branch 9 times, most recently from f99272f to ba0e77d Compare September 21, 2026 14:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL