Fix Bun compatibility and N-API reference teardown - #7
yumin-chen wants to merge 7 commits into
Conversation
Sorry, something went wrong.
Require node >= 22 and use NAPI_VERSION=10
- Link -lcrypto and -lssl on Linux non-Electron builds in binding.gyp so host engines like Bun can dlopen nodegit.node - Call owner.SuppressDestruct() in NodeGitWrapper to prevent HandleScope errors during environment teardown - Check callback validity in reference/unreference callbacks to avoid bad_function_call exceptions - Fix invalid assert.false and assert.gt calls in test/tests/clone.js Co-authored-by: yumin-chen <10954839+yumin-chen@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back! New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Sorry, something went wrong.
- Link -lcrypto and -lssl on Linux non-Electron builds in binding.gyp so host engines like Bun can dlopen nodegit.node - Wrap owner in std::unique_ptr<Napi::ObjectReference> in NodeGitWrapper and call SuppressDestruct() to prevent HandleScope errors during environment teardown - Call SuppressDestruct() and delete underlying reference in TrackerWrap destructor - Check callback validity in reference/unreference callbacks to avoid bad_function_call exceptions - Fix invalid assert.false and assert.gt calls in test/tests/clone.js Co-authored-by: yumin-chen <10954839+yumin-chen@users.noreply.github.com>
This change fixes compatibility issues when running NodeGit under Bun and addresses review queries:
PR created automatically by Jules for task 883390392492057550 started by @yumin-chen