fix: add HandleScope during N-API environment cleanup - #8
yumin-chen wants to merge 6 commits into
Conversation
Sorry, something went wrong.
Require node >= 22 and use NAPI_VERSION=10
Ensure that context destruction and tracker wrap deletion occur inside a
valid Napi::HandleScope in AsyncContextCleanupHandle::AsyncCleanupContext.
This prevents V8 fatal errors ("Cannot create a handle without a HandleScope")
during process/environment teardown.
Co-authored-by: yumin-chen <10954839+yumin-chen@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back! New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Sorry, something went wrong.
Fixed the V8 fatal error (FATAL ERROR: v8::HandleScope::CreateHandle() Cannot create a handle without a HandleScope) during N-API environment cleanup by introducing a Napi::HandleScope in AsyncContextCleanupHandle::AsyncCleanupContext while resetting and destroying the Context instance.
PR created automatically by Jules for task 2077547183568070349 started by @yumin-chen