Migrate NodeGit native bindings from NAN to Node-API - #9
yumin-chen wants to merge 6 commits into
Conversation
Sorry, something went wrong.
- Update generator templates and manual C++ wrappers to use node-addon-api (napi.h). - Configure binding.gyp to define NAPI_CPP_EXCEPTIONS and compiler flags. - Refactor v8_helpers.h using std::enable_if for arithmetic types. - Fix AsyncWorker persistent storage and memory lifetime management. - Wrap MakeCallback calls in async callbacks with try/catch for Napi::Error. - Fix TrackerWrap intrusive list unlinking and tree cleanup during environment shutdown. Co-authored-by: yumin-chen <10954839+yumin-chen@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back! New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Sorry, something went wrong.
Migrated NodeGit's C++ bindings and template generator architecture from NAN (nan.h) to Node-API (node-addon-api / napi.h).
Summary of Changes:
PR created automatically by Jules for task 16678422678852110768 started by @yumin-chen