Upgrade ClickHouse JDBC driver from 0.3.2 to 0.9.6 - #2
Merged
alexey-milovidov merged 1 commit intoMar 2, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The old driver (ru.yandex.clickhouse:clickhouse-jdbc:0.3.2) failed to decompress error responses from the server, throwing "Magic is not correct" IOException instead of reporting the actual ClickHouse error message. This caused SQLancer to treat expected errors (like ILLEGAL_TYPE_OF_ARGUMENT) as assertion failures, because the JDBC exception message didn't contain the expected error substrings. Changes: - Update Maven dependency from ru.yandex.clickhouse:clickhouse-jdbc:0.3.2 to com.clickhouse:clickhouse-jdbc:0.9.6 (with "all" classifier) - Update all imports from com.clickhouse.client.ClickHouseDataType to com.clickhouse.data.ClickHouseDataType (package was renamed) - Add "Magic is not correct" to expected errors as safety net Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fm4v
added a commit
that referenced
this pull request
Jun 24, 2026
…ide-int types + EET roundtrip identities) Implements the plan's Phase-1 P0 fast wins from docs/plans/2026-06-13-001-feat-clickhouse-coverage-backlog-30-ideas-plan.md. New differential / ground-truth oracles (each default-on, gated by a --flag, self-contained, soundness-checklist-compliant): - #2 PrewhereEquivalence WHERE == PREWHERE == optimize_move_to_prewhere=0 (multiset) - #3 ReadInOrderToggle optimize_read_in_order/aggregation_in_order on==off - #4 CountOptimization trivial/implicit/use_projections on==off + countIf cross-check + GROUP-BY-key count arm (hardens #106573, #106125) - #5 LazyMaterializationToggle query_plan_optimize_lazy_materialization on==off (positional) - #12 ReplacingDedup ReplacingMergeTree(ver) FINAL == argMax(val,ver) GROUP BY key - sqlancer#19 QuantileConsistency quantileExact==medianExact, monotone-in-level, Low<=Exact<=High - sqlancer#20 UniqExactness uniqExact == count(DISTINCT) == length(groupUniqArray) - sqlancer#21 ArgExtremum argMax / arraySort(groupArray) / groupArraySorted vs Java truth - sqlancer#28 MaterializedColumn MATERIALIZED/ALIAS col == defining expr (single-snapshot) Generator/catalog: - sqlancer#16 emit signed Int128/Int256 + Decimal256 (Decimal precision 39..76); Interval column emission deliberately NOT added (ClickHouse forbids storing Interval in tables); ClickHouseTypeParser gains an Interval read-back branch for free. - sqlancer#23 EET roundtrip identities: unhex(hex), base64Decode(base64Encode), tryBase64Decode(base64Encode), toIPv4(IPv4NumToString(toUInt32)), toIPv6(IPv6NumToString) -- each type-gated; +7 unit-test cases. Wired into ClickHouseOracleFactory, ClickHouseOptions (--*-oracle flags) and .claude/run-sqlancer.sh ALL_ORACLES. mvn compile green; EETIdentitiesTest 20/20. Probe-on-head items (recorded for dev-vm validation): query_plan_optimize_lazy_materialization, read_in_order_use_buffering, optimize_trivial_count_query family, groupArraySorted/array text format, IPv6 IPv4-mapped roundtrip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The old JDBC driver (0.3.2) fails to properly handle compressed error responses from the ClickHouse server. When a query fails (e.g., ILLEGAL_TYPE_OF_ARGUMENT during table creation), the server sends an error response, but the old driver tries to decompress it using ClickHouse native LZ4 and fails with:
java.io.IOException: Magic is not correct - expect [-126] but got [-63] at com.clickhouse.client.data.ClickHouseLZ4InputStream.readNextBlockThis prevents SQLancer from matching the error against the expected errors list, causing it to throw AssertionError for every table creation failure. As a result, all 6 SQLancer tests report "Executed 0 queries" because database generation never completes.
Testing
Tested in ClickHouse CI: https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=98390&sha=3836c590894a3143dd6e2acfe182cb299b2e598a&name_0=PR&name_1=SQLancer%20%28amd_debug%29