fix(vitest-plugin): migrate deprecated vitest 4.1 imports - #75
Draft
adriencaccia wants to merge 1 commit into
Draft
fix(vitest-plugin): migrate deprecated vitest 4.1 imports#75adriencaccia wants to merge 1 commit into
adriencaccia wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…e imports Vitest 4.1 deprecated the `vitest/runners` and `vitest/suite` subpath imports, printing console warnings on every load. Introduce a compat module that dynamically resolves imports: on vitest 4.1+ it uses the main `vitest` entry point (BenchmarkRunner, TestRunner statics), and on vitest 3.x it falls back to the old subpath imports (no warnings on either version). Also bump vitest devDependency from 4.0.18 to 4.1.1, revert vite devDependency to ^7 to keep compatibility with Node 20.5.1 (vite 8 + rolldown requires Node 20.19+), and remove the now-unnecessary rolldown devDependency and tsconfig paths workaround. Co-Authored-By: Claude <noreply@anthropic.com>
Copy link
Copy Markdown
Merging this PR will degrade performance by 61.43%⚡ 9 improved benchmarks
Performance Changes
Comparing feat/bump-vitest-4.1 (d104278) with feat/vite-8-support (1a48730) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate away from deprecated vitest/runners and vitest/suite subpath imports.
Vitest 4.1 deprecated these subpath imports, printing console.warn on every load:
Since the plugin still supports vitest 3.2 (which doesn't export from the main entry), a compat module (src/compat.ts) dynamically resolves the correct import path at runtime using top-level await:
Verified locally with codspeed run — both simulation and walltime modes work on vitest 4.1.1 (no deprecation warnings) and vitest 3.2.4 (backwards compatible).
Other changes: