fix: explicitely disable instrument hooks warnings - #164
Open
art049 wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
CodSpeed Performance ReportMerging this PR will degrade performance by 71.43%Comparing fix/instrument-hooks-options (017f605) with main (a8754dd) Summary⚡ 15 improved benchmarks
Performance Changes
|
Sorry, something went wrong.
not-matthias
approved these changes
Jan 26, 2026
GuillaumeLagrange
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@not-matthias, we should be explicit about the warnings to ignore, skipping them all would create unseen issues
(bumped into that while building the exec-harness which needs most of those flags and we don't want to skip all warnings)