FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Update the codebase to PHP 8.1 by TavoNiievez · Pull Request #6747 · Codeception/Codeception · GitHub

/ Codeception Public

Update the codebase to PHP 8.1 - #6747

Merged
TavoNiievez merged 5 commits into
Codeception:5.2from
TavoNiievez:5.1
May 29, 2024
ConversationCommits (5)ChecksFiles changed
Merged

Update the codebase to PHP 8.1#6747
TavoNiievez merged 5 commits into
Codeception:5.2from
TavoNiievez:5.1

Conversation

TavoNiievez commented Mar 19, 2024

Copy link
Copy Markdown
Member

I cherry-picked the commit from my other PR (#6746) to demonstrate that the tests run correctly.
I will delete it as soon as it is merged.

This PR should be merged with the Squash and merge strategy.

TavoNiievez requested a review from Naktibalda March 20, 2024 22:14
TavoNiievez commented Mar 21, 2024
View reviewed changes
Comment thread src/Codeception/Codecept.php
TavoNiievez marked this pull request as ready for review April 1, 2024 05:19
Naktibalda requested changes Apr 4, 2024
View reviewed changes

Naktibalda left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What version is it going to be? 5.2.0? 6.0.0?

I think that 5.1 branch should stay compatible with PHP 8.0 in cases there is some critical bug that must be fixed.

Comment thread tests/unit/Codeception/ConfigurationTest.php Outdated
Comment thread tests/unit/Codeception/Coverage/FilterTest.php

TavoNiievez commented Apr 4, 2024

Copy link
Copy Markdown
Member Author

@Naktibalda In my PR for the command folder I also had to move the minimum version of Symfony to 5.4.

I don't plan to add any breaking changes, I'm just going to remove inconsistencies in the code where I find them or rewrite small pieces of code for some simpler or more modern alternative from a Symfony or PHP version point of view.
Considering this, it can be called 5.2
People who need Symfony 4.4 or PHP 8.0 can stay on Codeception 5.1 and those who can upgrade will do so without having to change anything in their code.

TavoNiievez requested a review from Naktibalda April 9, 2024 15:46
Naktibalda changed the base branch from 5.1 to 5.2 May 16, 2024 17:03
TavoNiievez mentioned this pull request May 16, 2024
Closed
TavoNiievez merged commit 17b6765 into Codeception:5.2 May 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Naktibalda Naktibalda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL