Simplify Lib classes - #6767
Conversation
Sorry, something went wrong.
|
Wow, that's nice! |
Sorry, something went wrong.
I'd say just merge this! |
Sorry, something went wrong.
|
@TavoNiievez what's your confidence level on this? Can I go ahead and merge this or do you feel there's specific things that need an extra good look? |
Sorry, something went wrong.
|
@SamMousa Well, I had gotten used to Naktibalda checking me this kind of PR where I change many things at once, since he is (or was?) who had a more general knowledge about what is susceptible to generate problems if changed, even if the tests are going OK. If I had to answer your question I would say 85% sure that all changes were applied safely. |
Sorry, something went wrong.
|
I'm gonna defer to him, and gonna ping him hoping he'll give the okay then! @Naktibalda you up for reviewing this? |
Sorry, something went wrong.
|
I rechecked the changes I introduced in this PR and I think it is ready. I'm going to continue with another folder so I'm going to go ahead with this. |
Sorry, something went wrong.
This is a regression bugfix for release 5.2.0. With Codeception#6767 the ParamsLoader was streamlined, but when previously `$paramsFile` was passed to the loader methods, now only `$paramStorage` is passed, which misses getting converted to an absolute path via `codecept_absolute_path()`. This patch restores utilizing `$paramsFile` and also uses that to emit warnings when a file cannot be loaded. This bug caused missing file resolving, because software like TYPO3 for example executes tests from the repo directory `typo3/sysext/core/Tests/codeception.yml` and uses: ``` params: - parameters.yml - env.yml ``` and expects that the file is found next to the `codeception.yml` file in the same directory, and thus a breaking change.
300 additions & 419 deletions.