Declare nullable parameter types explicitly for PHP 8.4 compatibility - #6774
Merged
TavoNiievez merged 1 commit intoJul 28, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
burned42
approved these changes
Jul 26, 2024
burned42
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM 👍
Sorry, something went wrong.
TavoNiievez
approved these changes
Jul 26, 2024
TavoNiievez
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks good, thank you!
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@W0rma Do you think you can raise a PR for the 5.2 branch as well? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
@TavoNiievez Sure - see #6775 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wiki.php.net/rfc/deprecate-implicitly-nullable-types deprecates implicitly nullable parameter types in PHP 8.4