Simplify Test classes - #6845
Merged
TavoNiievez merged 1 commit intoApr 28, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
TavoNiievez
force-pushed
the
simplify_test
branch
30 times, most recently
from
57fd083 to
77c5b6e
Compare
April 23, 2025 19:33
TavoNiievez
force-pushed
the
simplify_test
branch
3 times, most recently
from
9cb446e to
739d91e
Compare
April 23, 2025 23:03
TavoNiievez
force-pushed
the
simplify_test
branch
from
65a79f6 to
ba51619
Compare
April 23, 2025 23:27
TavoNiievez
marked this pull request as ready for review
April 23, 2025 23:30
W0rma
approved these changes
Apr 28, 2025
W0rma
reviewed
May 12, 2025
Comment thread
src/Codeception/Test/Unit.php
Comment on lines
+84
to
+86
| if (property_exists($this, $property)) { | ||
| $this->{$property} = $di->instantiate($actor); | ||
| } |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
@TavoNiievez This check breaks some tests in one of my own projects if I try to access $this->tester. Error message: Undefined property: xxxTest::$tester
The test works fine if I remove the if clause and just call $this->{$property} = $di->instantiate($actor);
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
@W0rma Sounds like you're right. Could you open a PR with something like this:
$di = $this->getMetadata()->getService('di');
if (($actor = $this->getMetadata()->getCurrent('actor')) &&
($property = lcfirst((string) Configuration::config()['actor_suffix']))) {
$this->{$property} = $di->instantiate($actor);
}?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
@TavoNiievez See #6856
The change fixes the tests of my own project.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.