A previous PR set the return type of Actor::__call() to 'never'. This means that any classes that inherit from Actor must also declare __call() with return type 'never'. Any "tester" classes that use __call() to delegate or proxy other services will fail. Additionally, the PHP documentation specifies a return type of 'mixed" for __call(). See https://www.php.net/manual/en/language.oop5.overloading.php#object.call.
Thank you for accepting this PR.
Example of our usage ...
/**
* Defer unhandled methods to the current page
*/
public function __call($method, $args)
{
// get the current page class name.
// via Reflection, locate the method to be called
// via Reflection, invoke it so it can receive a standard argument list
try {
$currentPage = $this->getCurrentPage();
$cl = new ReflectionClass($currentPage);
$meth = $cl->getMethod($method);
return $meth->invokeArgs($currentPage, $args);
} catch (ReflectionException $e) {
$msg = "Method $method does not exist in class '" . self::class . "'";
if (isset($cl)) {
$msg = $msg . ", or in class '" . $cl->getName() . "'";
} else {
$msg = $msg . "; There is NO current page object to use to attempt execution.";
}
throw new Exception($msg, null, $e);
}
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A previous PR set the return type of Actor::__call() to 'never'. This means that any classes that inherit from Actor must also declare __call() with return type 'never'. Any "tester" classes that use __call() to delegate or proxy other services will fail. Additionally, the PHP documentation specifies a return type of 'mixed" for __call(). See https://www.php.net/manual/en/language.oop5.overloading.php#object.call.
Thank you for accepting this PR.
Example of our usage ...
/** * Defer unhandled methods to the current page */ public function __call($method, $args) { // get the current page class name. // via Reflection, locate the method to be called // via Reflection, invoke it so it can receive a standard argument list try { $currentPage = $this->getCurrentPage(); $cl = new ReflectionClass($currentPage); $meth = $cl->getMethod($method); return $meth->invokeArgs($currentPage, $args); } catch (ReflectionException $e) { $msg = "Method $method does not exist in class '" . self::class . "'"; if (isset($cl)) { $msg = $msg . ", or in class '" . $cl->getName() . "'"; } else { $msg = $msg . "; There is NO current page object to use to attempt execution."; } throw new Exception($msg, null, $e); } }