| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
Don't use toArray(String[]::new), use toArray(new String[0]) instead when converting from a List<String> (especially an ArrayList<String>) to a String[]
Sorry, something went wrong.
|
I'm not entirely sold on the naming convention of "raw", but I don't have any better ideas. |
Sorry, something went wrong.
|
Well, I thought that if something wasn't dealt with already, it exists in its raw form... |
Sorry, something went wrong.
If you're happy with it, I'm happy with it. I got nothing. Just have to make sure it's clear in the documentation what we mean by a "raw" argument as not to cause any misunderstandings. |
Sorry, something went wrong.
|
Other than writing documentation for this, is this feature-complete? |
Sorry, something went wrong.
|
Yeah, I think so. |
Sorry, something went wrong.
|
I'm only willing to merge this when documentation has been written. Good shout for adding tests, I forgot about that! |
Sorry, something went wrong.
|
About the documentation, currently I am not very motivated to do this (partly because I want to add a complete new page for the CommandArguments class) so I will get to it at some point later. |
Sorry, something went wrong.
Fair enough, I've still not even started working on the overhauled annotation system yet. These things just happen!
Yes, this is not an urgent feature, feel free to take all the time you need. |
Sorry, something went wrong.
There was a problem hiding this comment.
Just some quick looks at the code. Only little tweaks that don't really have a big impact either way, so you could totally just resolve the comments and not use them if you think the current way is fine.
Sorry, I couldn't get to the documentation because I have to go now. I can just suggest looking through the GitHub Actions failures, which is complaining about the spacing between some of the lines (all lines should have 1 empty line between them).
Sorry, something went wrong.
…ethods for raw arguments
There was a problem hiding this comment.
Documentation reviewed as requested. I've requested a couple changes, notably:
There's a lot of repetition with the node name and accessing by index under each section! After a long think about it, I'm going to approve that - I don't think it needs changing, but ensure that when it comes to writing examples you keep them concise - an example isn't necessary for every single method and once you've given an example of one concept you don't have to repeat it for every one (for example, you can write an example for get(String) and get(int), an example for getOrDefault(String, Object/Supplier) and getOptional(String) in the "Access arguments" section. In the "access raw arguments" section, an example of just accessing getRaw(String) would be sufficient and likewise with the "access unsafe arguments" section - an example of getUnchecked(String) would be sufficient).
An explanation at the top of "access raw arguments" is necessary to let users know what we're talking about (refactoring the explanation in "What terms are used" to this section would make a lot of sense here). Likewise with unsafe arguments.
Hopefully this review isn't too long!
Sorry, something went wrong.
…ng with raw arguments
…with CommandArguments#fullInput
There was a problem hiding this comment.
Other than the issue with JavaDocs for the CommandArguments record, we're ready to merge.
Sorry, something went wrong.
…CommandAPI into dev/raw-argument-input
| Back | FazBrowse Home | New Git URL |
I think this needs a little bit more work but I am still opening the PR now
ToDo's: