Delayed Commands example project - #460
Draft
willkroboth wants to merge 4 commits into
Draft
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
willkroboth
force-pushed
the
dev/delayed-commands-example
branch
2 times, most recently
from
f841508 to
e418207
Compare
June 8, 2023 22:11
willkroboth
force-pushed
the
dev/delayed-commands-example
branch
from
97d95b3 to
0f556a2
Compare
June 13, 2023 11:20
willkroboth
force-pushed
the
dev/delayed-commands-example
branch
from
8175399 to
0270eca
Compare
August 17, 2023 21:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a "delayed commands" example project to resolve #451.
After some discussion on Discord, the general idea was that the CommandAPI is focused on providing an interface to achieve features with commands that are hard to do without Brigadier or NMS code. Delayed commands are possible with Spigot API, so they probably won't be added directly to the CommandAPI.
However, it is possible to create a delayed command using the CommandAPI. Hopefully, this example project will help guide developers in creating their own system, or they can just copy the code :P.
This PR is currently a draft because I haven't actually made any delayed commands. I have an idea of how I would make it work, and I'll implement that eventually. However, if anyone has their own system for creating delayed commands, feel free to add it to the example. You can either comment something here or open a PR to the head branch, willkroboth/dev/delayed-commands-example.
TODO: