Replace the NMS implementation of resendPackets with Player.updateCommands - #471
Merged
JorelAli merged 2 commits intoJul 21, 2023
Merged
Replace the NMS implementation of resendPackets with Player.updateCommands#471JorelAli merged 2 commits into
JorelAli merged 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
willkroboth
approved these changes
Jul 21, 2023
DerEchtePilz
approved these changes
Jul 21, 2023
Copy link
Copy Markdown
Member
|
Worth putting a mention in the global changelog so we can keep track of this change for the next release. |
Sorry, something went wrong.
willkroboth
added a commit
to willkroboth/CommandAPI
that referenced
this pull request
Jul 24, 2023
Rebased CommandAPI#471 into runtime registering (CommandAPI#417)
willkroboth
added a commit
to willkroboth/CommandAPI
that referenced
this pull request
Jul 26, 2023
Rebased CommandAPI#471 into runtime registering (CommandAPI#417)
willkroboth
added a commit
to willkroboth/CommandAPI
that referenced
this pull request
Aug 6, 2023
Rebased CommandAPI#471 into runtime registering (CommandAPI#417)
willkroboth
added a commit
to willkroboth/CommandAPI
that referenced
this pull request
Aug 11, 2023
Rebased CommandAPI#471 into runtime registering (CommandAPI#417)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Player.updateCommands has been in the Bukkit API since August 2018 and performs the same actions as the NMS implementations (with an additional check that the player is actually connected to the server).
I also tested it and to no surprise it works like before