Hotfix CommandAPI throwing errors because of Paper's Brigadier command API - #555
Merged
DerEchtePilz merged 2 commits intoMay 12, 2024
Merged
Hotfix CommandAPI throwing errors because of Paper's Brigadier command API#555DerEchtePilz merged 2 commits into
DerEchtePilz merged 2 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Regards Paper 1.20.6, build 65+, they've merged the Brigadier command API and removed the vanillaCommandDispatcher field.
+ fixed exception appearing in server log, this isn't done with VarHandles but I think because this is a hotfix, it is fine for now. I will handle all this properly on dev/commandapi-paper and #517
Copy link
Copy Markdown
|
I gave this PR a quick spin with my plugin and it seems to work without any issues |
Sorry, something went wrong.
JorelAli
reviewed
May 27, 2024
Comment thread
...kkit-nms/commandapi-bukkit-nms-common/src/main/java/dev/jorel/commandapi/nms/NMS_Common.java
Comment on lines
+97
to
+107
| private static final Field commandDispatcher; | ||
|
|
||
| static { | ||
| Field temporary; | ||
| try { | ||
| temporary = MinecraftServer.class.getDeclaredField("vanillaCommandDispatcher"); | ||
| } catch (Exception e) { | ||
| temporary = null; | ||
| } | ||
| commandDispatcher = temporary; | ||
| } |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
A field that could be null that doesn't have @Nullable or wrapped in an Optional! 🫢
Sorry, something went wrong.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of this is not pretty but doing this the VarHandle-less way also got rid of the exception in the console which I didn't seem to do with VarHandles.
Nevertheless, this should make it possible to at least register commands using Paper 1.20.6 build 65 and onwards.
I plan to handle all this properly in #517