Fix registerCommand(Class<?>) with isolated class loaders - #698
Open
TheKinrar wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Uhh, I guess there's nothing wrong with this, however, if you depend on the CommandAPI plugin, shouldn't Paper put your plugin and the CommandAPI plugin on the same classpath and should therefore be able to load the classes just fine? |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
It's one-way only. Your plugin will be able to load CommandAPI classes, not the other way around |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new Paper variant of CommandAPI is a Paper plugin (with the paper-plugin.yml definition) so it gets an isolated class loader that cannot load classes from other plugins. Therefore it will fail to load a class generated with the annotation processor (unless CommandAPI is shaded).
This simply uses the already existing class loader to get the class locally, which is easy as we're already getting a Class, not only a name.