Repository navigation
fix: Evaluate conditions on description resources against the described resource - #2267
Open
jeswr wants to merge 1 commit into
Open
jeswr wants to merge 1 commit into
jeswr wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ed resource The conditions of a PATCH request on a description resource were checked against the description resource itself, for which the data accessor has no metadata. As a result, If-Match headers were ignored, except for If-Match: *, which always failed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NeSZT7mKQVVBn4vqTZ6CRn
4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
Conditions on a PATCH to a description resource are checked against the .meta identifier, which the accessor has no metadata for. So a non-matching If-Match is ignored and the PATCH succeeds, and If-Match: * always fails. They are now checked against the described resource, like hasResource already does. PUT and DELETE on description resources are already rejected, so only PATCH changes.
Added a unit test and an integration test in Conditions.test.ts (fails on main with 205 instead of 412).
I used Claude Code to help write this change. I have reviewed the content of this PR myself.
✅ PR check list