Repository navigation
fix: Generate ETags for description resources - #2269
Open
jeswr wants to merge 1 commit into
Open
jeswr wants to merge 1 commit into
jeswr wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Description resources had no modification date, so they were returned without an ETag or Last-Modified header, and clients could not make conditional requests on them. They now share the modification date of the resource they describe, which changes whenever the description does. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NeSZT7mKQVVBn4vqTZ6CRn
4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
Description resources (.meta) are returned without ETag or Last-Modified, so clients can't make conditional requests on them. They now take the modification date of the resource they describe, which also changes when the description is patched.
Added a unit test and an integration test in Conditions.test.ts (fails on main, no Last-Modified).
I used Claude Code to help write this change. I have reviewed the content of this PR myself.
✅ PR check list