Repository navigation
fix: Return 412 when If-Match or If-Unmodified-Since fails on GET and HEAD - #2270
Open
jeswr wants to merge 1 commit into
Open
jeswr wants to merge 1 commit into
jeswr wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
… HEAD RFC 9110, §13.2.2 evaluates If-Match and If-Unmodified-Since before If-None-Match and If-Modified-Since, and requires a 412 response when they fail, also for GET and HEAD requests. Previously all failing read conditions resulted in a 304 response. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NeSZT7mKQVVBn4vqTZ6CRn
4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✍️ Description
A GET or HEAD whose If-Match or If-Unmodified-Since condition fails currently gets a 304. RFC 9110 §13.2.2 says those two are checked first and fail with 412, for any method. A failing If-None-Match or If-Modified-Since still gives 304.
Added unit tests and an integration test in Conditions.test.ts (fails on main with 304).
I used Claude Code to help write this change. I have reviewed the content of this PR myself.
✅ PR check list