FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[WIP] Simple table level sharding implementation by auxten · Pull Request #129 · CovenantSQL/CovenantSQL · GitHub

/ CovenantSQL Public

[WIP] Simple table level sharding implementation - #129

Open
auxten wants to merge 29 commits into
developfrom
feature/shard
ConversationCommits (29)ChecksFiles changed
Open

[WIP] Simple table level sharding implementation#129
auxten wants to merge 29 commits into
developfrom
feature/shard

Conversation

auxten commented Dec 3, 2018

Copy link
Copy Markdown
Contributor
  1. Simple SELECT without GROUP, LIMIT offset, HAVING, DISTINCT
  2. Almost all kinds of INSERT without subqueries

auxten added 17 commits November 22, 2018 21:02

codecov Bot commented Dec 6, 2018

Copy link
Copy Markdown

Codecov Report

Merging #129 into develop will decrease coverage by 0.95%.
The diff coverage is 69.81%.

@@             Coverage Diff             @@
##           develop     #129      +/-   ##
===========================================
- Coverage    77.47%   76.51%   -0.96%     
===========================================
  Files          142      149       +7     
  Lines        10251    11115     +864     
===========================================
+ Hits          7942     8505     +563     
- Misses        1684     1910     +226     
- Partials       625      700      +75

codecov Bot commented Dec 6, 2018 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #129 into develop will increase coverage by 0.26%.
The diff coverage is 73.29%.

@@            Coverage Diff             @@
##           develop    #129      +/-   ##
==========================================
+ Coverage    76.74%     77%   +0.26%     
==========================================
  Files          146     151       +5     
  Lines        10890   11313     +423     
==========================================
+ Hits          8357    8712     +355     
- Misses        1845    1898      +53     
- Partials       688     703      +15

xq262144 reviewed Dec 17, 2018
View reviewed changes
Comment thread shard/engine.go Outdated
xq262144 reviewed Dec 17, 2018
View reviewed changes
Comment thread shard/engine.go Outdated
leventeliu reviewed Dec 17, 2018
View reviewed changes
Comment thread shard/engine_test.go Outdated
So(err, ShouldNotBeNil)
So(its, ShouldEqual, -1)
})
} No newline at end of file

leventeliu Dec 17, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

File is not formatted.

Comment thread shard/insert.go Outdated
Comment thread shard/insert.go
Comment thread shard/plan.go
xq262144 reviewed Dec 17, 2018
View reviewed changes
Comment thread shard/plan.go
rowCh <-chan []interface{}
)
for i, ins := range instructions {
colNames, _, rowCh, err = plan.selector(ctx, errCh, stopCh, ins, TempTableRowBufSize)

xq262144 Dec 17, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

colNames may not be the same schema as the original table.

xq262144 reviewed Dec 17, 2018
View reviewed changes
Comment thread shard/plan.go Outdated
auxten changed the title Simple table level sharding implementation [WIP] Simple table level sharding implementation Jan 3, 2019

stale Bot commented Apr 29, 2019

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale Bot added the wontfix This will not be worked on label Apr 29, 2019
auxten removed the wontfix This will not be worked on label Apr 30, 2019

stale Bot commented May 29, 2019

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. Please review @laodouya @auxten @xq262144 @leventeliu

stale Bot added the stale label May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

xq262144 xq262144 left review comments
leventeliu leventeliu left review comments
ggicci ggicci approved these changes
zeqing-guo Awaiting requested review from zeqing-guo

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL