FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Improve unit test cover ratio. by laodouya · Pull Request #251 · CovenantSQL/CovenantSQL · GitHub

/ CovenantSQL Public

Improve unit test cover ratio. - #251

Merged
xq262144 merged 18 commits into
developfrom
feature/unittest
Feb 18, 2019
ConversationCommits (18)ChecksFiles changed
Merged

Improve unit test cover ratio.#251
xq262144 merged 18 commits into
developfrom
feature/unittest

Conversation

laodouya commented Feb 15, 2019

Copy link
Copy Markdown
Member
  1. Improve unit test cover ratio.
  2. Fix minor bug
  3. Unit duplicate funcs
  4. Add test package for test support funcs and ingore test package cover ratio.

laodouya added 18 commits February 3, 2019 16:33
Add unit test for client package.
1a2779b
Update unit test bp config2.
d4f2225
Start local test server while testing defaultInit.
bb9693d
Add test case for functions that added in last commit.
d54da5e
Move worker common support test func to helper_test.go file
dbe8462
Combine two dupConf func into test.DupConf
f398f32
Replace node_standalone/config2.yaml to test.DupConf
ce3f5da
Add client.TransferToken test.
a0da709
Add client.UpdatePermission test.
d7eb5c1
Add runPeerListUpdater goroutine test.
4caa19a
Unit test cover rpc.ResetClient func.
1d82718
Fix one missing return bug. Incrase blockproducer unit test cover ratio
1931f20
Incrase blockproducer/metastate unit test cover ratio
31e7ca3
Move test support bp func to test package.
5c0fe24
Move DupConf to utils package.
b9f74b5
Rename bp.WaitDatabaseCreation to client.WaitBPDatabaseCreation.
6168bff
Imporve unit test cover for supportive code
efc8ecc
Imporve unit test cover for supportive code
6611843

codecov Bot commented Feb 15, 2019

Copy link
Copy Markdown

Codecov Report

Merging #251 into develop will increase coverage by 2.79%.
The diff coverage is 96.92%.

@@             Coverage Diff             @@
##           develop     #251      +/-   ##
===========================================
+ Coverage    75.88%   78.67%   +2.79%     
===========================================
  Files          159      160       +1     
  Lines        12198    12136      -62     
===========================================
+ Hits          9256     9548     +292     
+ Misses        2241     1906     -335     
+ Partials       701      682      -19

1 similar comment

codecov Bot commented Feb 15, 2019

Copy link
Copy Markdown

Codecov Report

Merging #251 into develop will increase coverage by 2.79%.
The diff coverage is 96.92%.

@@             Coverage Diff             @@
##           develop     #251      +/-   ##
===========================================
+ Coverage    75.88%   78.67%   +2.79%     
===========================================
  Files          159      160       +1     
  Lines        12198    12136      -62     
===========================================
+ Hits          9256     9548     +292     
+ Misses        2241     1906     -335     
+ Partials       701      682      -19

auxten approved these changes Feb 16, 2019
View reviewed changes

auxten left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Great

xq262144 approved these changes Feb 18, 2019
View reviewed changes

xq262144 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Approve

xq262144 merged commit 6efc92a into develop Feb 18, 2019
laodouya deleted the feature/unittest branch February 18, 2019 01:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

auxten auxten approved these changes
xq262144 xq262144 approved these changes
leventeliu Awaiting requested review from leventeliu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL