FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Combine createRandomBlock functions into one. by laodouya · Pull Request #258 · CovenantSQL/CovenantSQL · GitHub

/ CovenantSQL Public

Combine createRandomBlock functions into one. - #258

Merged
leventeliu merged 2 commits into
betafrom
feature/combine_test_funcs
Feb 18, 2019
ConversationCommits (2)ChecksFiles changed
Merged

Combine createRandomBlock functions into one.#258
leventeliu merged 2 commits into
betafrom
feature/combine_test_funcs

Conversation

laodouya commented Feb 18, 2019 •
edited
Loading

Copy link
Copy Markdown
Member
  1. Rename createRandomBlock functions to types.CreateRandomBlock
  2. Replace all createRandomBlock to reuse types.CreateRandomBlock
  3. Refactor createRandomBlock() in sqlchain/xxx_test.go to reuse types.CreateRandomBlock

laodouya changed the title [WIP] Combine createRandomBlock functions into one. Combine createRandomBlock functions into one. Feb 18, 2019
CovenantSQL deleted a comment from codecov Bot Feb 18, 2019
CovenantSQL deleted a comment from codecov Bot Feb 18, 2019

codecov Bot commented Feb 18, 2019

Copy link
Copy Markdown

Codecov Report

Merging #258 into beta will decrease coverage by 0.12%.
The diff coverage is 92.3%.

@@            Coverage Diff             @@
##             beta     #258      +/-   ##
==========================================
- Coverage   78.97%   78.85%   -0.13%     
==========================================
  Files         159      159              
  Lines       11955    11981      +26     
==========================================
+ Hits         9442     9448       +6     
- Misses       1828     1846      +18     
- Partials      685      687       +2

xq262144 approved these changes Feb 18, 2019
View reviewed changes

xq262144 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Approve

leventeliu approved these changes Feb 18, 2019
View reviewed changes

leventeliu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

leventeliu merged commit b0c46a4 into beta Feb 18, 2019
leventeliu deleted the feature/combine_test_funcs branch February 18, 2019 10:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

xq262144 xq262144 approved these changes
leventeliu leventeliu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL