Add transaction hash as return value in create/drop - #259
Merged
leventeliu merged 3 commits intoFeb 19, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## beta #259 +/- ##
==========================================
+ Coverage 79.01% 79.38% +0.36%
==========================================
Files 159 159
Lines 11981 11982 +1
==========================================
+ Hits 9467 9512 +45
+ Misses 1829 1779 -50
- Partials 685 691 +6 |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report
@@ Coverage Diff @@
## beta #259 +/- ##
==========================================
- Coverage 79.01% 78.75% -0.26%
==========================================
Files 159 159
Lines 11981 11982 +1
==========================================
- Hits 9467 9437 -30
- Misses 1829 1857 +28
- Partials 685 688 +3 |
Sorry, something went wrong.
laodouya
approved these changes
Feb 19, 2019
laodouya
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
xq262144
reviewed
Feb 19, 2019
Comment thread
cmd/cql/main.go
xq262144
approved these changes
Feb 19, 2019
xq262144
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Approve
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now, cql tool can use the returned hash to check transaction status.