CQL-Proxy And CQL-ETH-Bridge - #359
Merged
auxten merged 76 commits intoAug 7, 2019
Merged
Conversation
added 30 commits
June 24, 2019 18:28
added 10 commits
July 2, 2019 14:59
xq262144
requested review from
auxten,
laodouya and
leventeliu
and removed request for
laodouya
July 5, 2019 03:37
auxten
reviewed
Jul 7, 2019
Comment thread
Makefile
| dep: | ||
| dep ensure -v | ||
| rm -rfv ./vendor/github.com/ethereum/go-ethereum/crypto/secp256k1/libsecp256k1/ | ||
| cp -av "$${GOPATH}/src/github.com/ethereum/go-ethereum/crypto/secp256k1/libsecp256k1/" ./vendor/github.com/ethereum/go-ethereum/crypto/secp256k1/libsecp256k1/ |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Why we need do this?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
The dep program will treat the libsecp256k1 c package as a unused golang package and remove it on prune stage. However if we disable prune for the ethereum dependency, whole ethereum source code will be merged into CovenantSQL. So a manually code sync is required.
Sorry, something went wrong.
laodouya
approved these changes
Aug 6, 2019
auxten
approved these changes
Aug 7, 2019
auxten
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Okey, but after that we should not use dep ensure, use make dep or dep ensure -add xxxPkg, dep ensure -update xxxPkg @laodouya @leventeliu
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.