| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Hi @aaronskiba I have a question about where the constant VALIDATION_MESSAGE_PASSWORDS_MATCH is used in the code. I presume it's when you reset your password but I see a different message when I try to save mismatched passwords. Can you tell me how to test if the constant is used as expected please? Thanks! |
Sorry, something went wrong.
Hi @gjacob24, Sorry for slow reply on this one. Also, this constant is a bit tricky to test locally, but here's one way.
<p>
Hello super_admin@example.com
</p>
<p>
Someone has requested a link to change your DMPRoadmap password. You can do this through the link below.
</p>
<p><a href="http://Aarons-Mac-mini/users/password/edit?reset_password_token=XpnsHx1Hwkqgx1yZzRbq">Change my password</a></p>
|
Sorry, something went wrong.
|
Hi @aaronskiba, thank you for explaining how to test the second one. Glad I asked because I noticed this page needed some polishing after the Bootstrap upgrade. |
Sorry, something went wrong.
There was a problem hiding this comment.
Both code changes work as expected. This PR can be merged into the development branch for the upcoming release.
Sorry, something went wrong.
Great to hear, thank you. Also, I finally added/committed a changelog entry for this one as well. :) |
Sorry, something went wrong.
Great, ok. I was going to suggest adding change log entries together in one commit for your PRs but I guess this is better. Thanks! |
Sorry, something went wrong.
Prior to this commit, requiredField.js was calling getConstant('REQUIRED_FIELD_TEXT') before the constant was loaded to constants.js. As a result, `asterisk` was evaluating to `undefined`.
getConstant('VALIDATION_MESSAGE_PASSWORDS_MATCH') still exists in passwordhelper.js
Was previously removed here: portagenetwork@33a6058
| Back | FazBrowse Home | New Git URL |
Fixes #3361
Changes proposed in this PR: