Repository navigation
Lower PostgreSQL GitHub Action Chrome Version to Address Breaking Changes Between Latest Chrome Version (134) and /features Tests - #3491
Merged
aaronskiba merged 4 commits intoMar 24, 2025
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
- This change provides a temporary workaround for the following GitHub Issue: #3485 - This commit should be reverted once our tests are able to run successfully with the latest version of Chrome.
aaronskiba
marked this pull request as ready for review
March 20, 2025 19:25
This change refactors `spec/features/modal_search_spec.rb` by adding a method which contains the modal logic shared between both of the tests within the file.
aaronskiba
force-pushed
the
aaron/issues/downgrade-chrome
branch
from
111ad9a to
cd3f480
Compare
March 20, 2025 21:01
johnpinto1
self-requested a review
March 24, 2025 09:30
johnpinto1
approved these changes
Mar 24, 2025
johnpinto1
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
The temporary Chrome downgrade sorts the failing test issues on Github. The refactoring suggested by Rubocop has been done.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # (Only a temporary fix for #3485)
Changes proposed in this PR: