FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix rendering of `confirm_merge` partial by aaronskiba · Pull Request #3515 · DMPRoadmap/roadmap · GitHub

Repository navigation

Fix rendering of confirm_merge partial - #3515

Merged
johnpinto1 merged 2 commits into
developmentfrom
aaron/fix-confirm-merge-partial
Apr 24, 2025
Merged

johnpinto1 merged 2 commits into
developmentfrom
aaron/fix-confirm-merge-partial

Conversation

Copy link
Copy Markdown
Contributor

Changes proposed in this PR:

  • This change simplifies the partial naming by taking advantage of Rails' naming conventions and resolves the following error / Rails 7 breaking change:
ActionView::MissingTemplate - Missing partial super_admin/users/_confirm_merge.html.erb with {:locale=>[:"en-CA", :en, :"en-GB"], :formats=>[:js, :html, :text, :css, :ics, :csv, :vcf, :vtt, :png, :jpeg, :gif, :bmp, :tiff, :svg, :webp, :mpeg, :mp3, :ogg, :m4a, :webm, :mp4, :otf, :ttf, :woff, :woff2, :xml, :rss, :atom, :yaml, :multipart_form, :url_encoded_form, :json, :pdf, :zip, :gzip, :docx, :turbo_stream], :variants=>[], :handlers=>[:raw, :erb, :html, :builder, :ruby, :jbuilder]}.
...
  app/controllers/super_admin/users_controller.rb:94:in `search'
  • The prior 'super_admin/users/confirm_merge.html.erb' code works with releasev4.2, which uses Rails 6. However, it generates the following deprecation warning:
DEPRECATION WARNING: Rendering actions with '.' in the name is deprecated: super_admin/users/_confirm_merge.html.erb (called from search at /home/aaron/Documents/GitHub/roadmap_upstream/app/controllers/super_admin/users_controller.rb:94)

- This change simplifies the partial naming by taking advantage of Rails' naming conventions and resolves the following error:
```
ActionView::MissingTemplate - Missing partial super_admin/users/_confirm_merge.html.erb with {:locale=>[:"en-CA", :en, :"en-GB"], :formats=>[:js, :html, :text, :css, :ics, :csv, :vcf, :vtt, :png, :jpeg, :gif, :bmp, :tiff, :svg, :webp, :mpeg, :mp3, :ogg, :m4a, :webm, :mp4, :otf, :ttf, :woff, :woff2, :xml, :rss, :atom, :yaml, :multipart_form, :url_encoded_form, :json, :pdf, :zip, :gzip, :docx, :turbo_stream], :variants=>[], :handlers=>[:raw, :erb, :html, :builder, :ruby, :jbuilder]}.
...
  app/controllers/super_admin/users_controller.rb:94:in `search'
```

- The prior `'super_admin/users/confirm_merge.html.erb'` code works with release`v4.2`, which uses Rails 6. However, it generates the following deprecation warning:
```
DEPRECATION WARNING: Rendering actions with '.' in the name is deprecated: super_admin/users/_confirm_merge.html.erb (called from search at /home/aaron/Documents/GitHub/roadmap_upstream/app/controllers/super_admin/users_controller.rb:94)
```
aaronskiba force-pushed the aaron/fix-confirm-merge-partial branch from a0a5078 to 989e3ea Compare April 24, 2025 15:13
johnpinto1 merged commit 4bbaa34 into development Apr 24, 2025
aaronskiba deleted the aaron/fix-confirm-merge-partial branch August 6, 2025 14:14
aaronskiba restored the aaron/fix-confirm-merge-partial branch October 6, 2025 16:38
aaronskiba deleted the aaron/fix-confirm-merge-partial branch October 6, 2025 16:59
aaronskiba restored the aaron/fix-confirm-merge-partial branch October 6, 2025 17:01
aaronskiba deleted the aaron/fix-confirm-merge-partial branch October 6, 2025 17:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL