Refactor the sep_param method in usage_controller to validate that the provided CSV field separator is a safe, predefined character.
This mitigates a CSV injection vulnerability where a crafted request such as
/usage_yearly_users?sep=%2c%3dcmd|' /C+powershell'!A0++pbiqh
could embed a malicious formula into the downloaded CSV. When opened in spreadsheet software (like Excel), it could trigger command execution under certain conditions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CSV separators not being validated.
Changes proposed in this PR:
/usage_yearly_users?sep=%2c%3dcmd|' /C+powershell'!A0++pbiqh
could embed a malicious formula into the downloaded CSV. When opened in spreadsheet software (like Excel), it could trigger command execution under certain conditions.